Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3975)

Unified Diff: cc/layers/texture_layer_unittest.cc

Issue 2757373002: Fixing flakiness of TextureLayerChangeInvisibleMailboxTest (Closed)
Patch Set: c Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/trees/single_thread_proxy.h » ('j') | cc/trees/single_thread_proxy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/texture_layer_unittest.cc
diff --git a/cc/layers/texture_layer_unittest.cc b/cc/layers/texture_layer_unittest.cc
index 8a48770e190864b0083acc85055b657aab31cd86..54c318dfd1f07b4d24388d50013a0c878cd7eb72 100644
--- a/cc/layers/texture_layer_unittest.cc
+++ b/cc/layers/texture_layer_unittest.cc
@@ -1187,16 +1187,6 @@ class TextureLayerChangeInvisibleMailboxTest
void MailboxReleased(const gpu::SyncToken& sync_token, bool lost_resource) {
EXPECT_TRUE(sync_token.HasData());
++mailbox_returned_;
- switch (mailbox_returned_) {
- case 1:
- break;
- case 2:
- EXPECT_EQ(commit_count_, 5);
- EndTest();
- break;
- default:
- NOTREACHED();
- }
}
void SetupTree() override {
@@ -1226,7 +1216,7 @@ class TextureLayerChangeInvisibleMailboxTest
void BeginTest() override { PostSetNeedsCommitToMainThread(); }
- void DidCommitAndDrawFrame() override {
+ void DidReceiveCompositorFrameAck() override {
++commit_count_;
switch (commit_count_) {
case 1:
@@ -1261,6 +1251,8 @@ class TextureLayerChangeInvisibleMailboxTest
texture_layer_->ClearClient();
break;
case 5:
+ EXPECT_EQ(2, mailbox_returned_);
+ EndTest();
break;
default:
NOTREACHED();
« no previous file with comments | « no previous file | cc/trees/single_thread_proxy.h » ('j') | cc/trees/single_thread_proxy.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698