Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: tools/perf/benchmarks/v8_browsing.py

Issue 2757283002: Enable EQT metric for v8.browsing* benchmarks. (Closed)
Patch Set: fix comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/v8_browsing.py
diff --git a/tools/perf/benchmarks/v8_browsing.py b/tools/perf/benchmarks/v8_browsing.py
index 5c026a0fe45a638db68011b8867714fc834beedd..b43d046ac5b92e608d194d3644db50458d2e35be 100644
--- a/tools/perf/benchmarks/v8_browsing.py
+++ b/tools/perf/benchmarks/v8_browsing.py
@@ -42,6 +42,11 @@ class _V8BrowsingBenchmark(perf_benchmark.PerfBenchmark):
'-*',
# Memory categories.
'disabled-by-default-memory-infra',
+ # EQT categories.
+ 'blink.user_timing',
+ 'loading',
+ 'navigation',
+ 'toplevel',
# V8 categories.
'blink.console',
'disabled-by-default-v8.gc',
@@ -61,7 +66,8 @@ class _V8BrowsingBenchmark(perf_benchmark.PerfBenchmark):
memory_dump_config = chrome_trace_config.MemoryDumpConfig()
memory_dump_config.AddTrigger('light', 1000)
options.config.chrome_trace_config.SetMemoryDumpConfig(memory_dump_config)
- options.SetTimelineBasedMetrics(['v8AndMemoryMetrics'])
+ options.SetTimelineBasedMetrics([
+ 'expectedQueueingTimeMetric', 'v8AndMemoryMetrics'])
return options
def CreateStorySet(self, options):
@@ -81,8 +87,8 @@ class _V8BrowsingBenchmark(perf_benchmark.PerfBenchmark):
if 'v8-gc' in value.name:
return (_V8_GC_HIGH_LEVEL_STATS_RE.search(value.name) and
not _IGNORED_V8_STATS_RE.search(value.name))
- # Allow all other non-GC metrics.
- return 'v8' in value.name
+ # Allow all other metrics.
+ return True
@classmethod
def ShouldTearDownStateAfterEachStoryRun(cls):
@@ -105,6 +111,11 @@ class _V8RuntimeStatsBrowsingBenchmark(perf_benchmark.PerfBenchmark):
# UE categories requred by runtimeStatsTotalMetric to bucket
# runtimeStats by UE.
'rail',
+ # EQT categories.
+ 'blink.user_timing',
+ 'loading',
+ 'navigation',
+ 'toplevel',
# V8 categories.
'blink.console',
'disabled-by-default-v8.gc',
@@ -122,7 +133,8 @@ class _V8RuntimeStatsBrowsingBenchmark(perf_benchmark.PerfBenchmark):
memory_dump_config.AddTrigger('light', 1000)
options.config.chrome_trace_config.SetMemoryDumpConfig(memory_dump_config)
- options.SetTimelineBasedMetrics(['runtimeStatsTotalMetric', 'gcMetric'])
+ options.SetTimelineBasedMetrics([
+ 'expectedQueueingTimeMetric', 'runtimeStatsTotalMetric', 'gcMetric'])
return options
def CreateStorySet(self, options):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698