Issue 2757153002: update fasta scanner to generate two types of comments

Issue 2757153002: update fasta scanner to generate two types of comments (Closed)

Created:
3 years, 9 months ago by danrubel

Modified:
3 years, 9 months ago

Reviewers:
ahe, Paul Berry

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

update fasta scanner to generate two types of comments * replace fasta.COMMENT_INFO with fasta.SINGLE_LINE_COMMENT_INFO and fasta.MULTI_LINE_COMMENT_INFO so that it matches analyzer scanner output * added test for fasta.isUserDefinableOperator R=ahe@google.com, paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/08402f57895be1d7745375212e94d7acfa6f0ff1

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -26 lines)			Patch
M	pkg/analyzer/lib/src/fasta/token_utils.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart	View	6 chunks	+5 lines, -6 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/scanner/precedence.dart	View	3 chunks	+8 lines, -5 lines	0 comments	Download
M	pkg/front_end/lib/src/scanner/token.dart	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	pkg/front_end/test/precedence_info_test.dart	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	pkg/front_end/test/token_test.dart	View	1 chunk	+44 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

danrubel

3 years, 9 months ago (2017-03-20 19:12:35 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
08402f57895be1d7745375212e94d7acfa6f0ff1 (presubmit successful).