Issue 275713002: Revert of Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 275713002: Revert of Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines. (Closed)

Created:
6 years, 7 months ago by robertphillips

Modified:
6 years, 7 months ago

Reviewers:
Dominik Grewe, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Revert of Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines. (https://codereview.chromium.org/265973002/) Reason for revert: This is breaking compilation of cc_unittests in Chrome Original issue's description: > Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines. > > Chrome/Blink doesn't use any of the legacy methods behind this flag any more. > > BUG=skia:2187 > > Committed: http://code.google.com/p/skia/source/detail?r=14651 TBR=reed@google.com,dominikg@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:2187 Committed: http://code.google.com/p/skia/source/detail?r=14660