Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1669)

Unified Diff: base/debug/stack_trace_unittest.cc

Issue 2757123002: Cleaner fall-back stack capture for --enable-heap-profiling=native. (Closed)
Patch Set: Fix OS_NACL Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/debug/stack_trace_unittest.cc
diff --git a/base/debug/stack_trace_unittest.cc b/base/debug/stack_trace_unittest.cc
index 79b0cb84055ecd04311ad45425e71ff82214f387..179bde0ad38267bd38b1b250c4c148c80921815f 100644
--- a/base/debug/stack_trace_unittest.cc
+++ b/base/debug/stack_trace_unittest.cc
@@ -254,10 +254,8 @@ TEST_F(StackTraceTest, itoa_r) {
}
#endif // defined(OS_POSIX) && !defined(OS_ANDROID)
-#if HAVE_TRACE_STACK_FRAME_POINTERS && !defined(OS_WIN)
-// Windows x64 binaries cannot be built with frame pointer, and MSVC doesn't
-// provide intrinsics to query the frame pointer even for the x86 build, nor
-// does it allow us to take the address of labels, so skip these under Windows.
+#if HAVE_TRACE_STACK_FRAME_POINTERS()
+
template <size_t Depth>
void NOINLINE ExpectStackFramePointers(const void** frames,
size_t max_depth) {
@@ -315,7 +313,7 @@ TEST_F(StackTraceTest, MAYBE_StackEnd) {
EXPECT_NE(0u, GetStackEnd());
}
-#endif // HAVE_TRACE_STACK_FRAME_POINTERS && !defined(OS_WIN)
+#endif // HAVE_TRACE_STACK_FRAME_POINTERS()
} // namespace debug
} // namespace base

Powered by Google App Engine
This is Rietveld 408576698