fasta.Token implement analyzer.Token

fasta.Token implement analyzer.Token

* fasta.Token implements analyzer.Token
* cleanup and improve PrecedenceInfo tests

R=ahe@google.com, paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/e93ad0d4fc32ab03fe70e252e9ea8021a492d343

[danrubel, 2017-03-19 14:13:02]

danrubel@google.com changed reviewers:
+ ahe@google.com, paulberry@google.com

[ahe, 2017-03-20 12:32:48]

lgtm

https://codereview.chromium.org/2757113002/diff/60001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/scanner/error_token.dart (right):

https://codereview.chromium.org/2757113002/diff/60001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/scanner/error_token.dart:85: throw 'unsupported
operation';
import '../errors.dart';

internalError("Unsupported operation.", null, charOffset);

https://codereview.chromium.org/2757113002/diff/60001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/scanner/token.dart (right):

https://codereview.chromium.org/2757113002/diff/60001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/scanner/token.dart:177: ..precedingComments =
copyComments(precedingComments) as Token;
Could you remove the casts from this file? As far as I know, downcasts aren't a
warning anymore. Perhaps you're using an old version of the analyzer.

https://codereview.chromium.org/2757113002/diff/60001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/scanner/token.dart:363: StringToken._(this.info,
this.valueOrLazySubstring, int charOffset)
I'd prefer a non-private name for this.

https://codereview.chromium.org/2757113002/diff/60001/pkg/front_end/lib/src/s...
File pkg/front_end/lib/src/scanner/token.dart (right):

https://codereview.chromium.org/2757113002/diff/60001/pkg/front_end/lib/src/s...
pkg/front_end/lib/src/scanner/token.dart:695: * Return a newly created token
that is a copy of this tokens
"this token" is kinda correct. Perhaps you want to say "this token and [next]
recursively"?

[Paul Berry, 2017-03-20 16:37:45]

lgtm

[danrubel, 2017-03-20 18:06:12]

Description was changed from

==========
fasta.Token implement analyzer.Token

* fasta.Token implements analyzer.Token
* cleanup and improve PrecedenceInfo tests
==========

to

==========
fasta.Token implement analyzer.Token

* fasta.Token implements analyzer.Token
* cleanup and improve PrecedenceInfo tests

R=ahe@google.com, paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e93ad0d4fc32ab03fe70e252e9ea8021a492d343
==========

[danrubel, 2017-03-20 18:06:14]

Committed patchset #5 (id:80001) manually as
e93ad0d4fc32ab03fe70e252e9ea8021a492d343 (presubmit successful).