Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/settings.cc

Issue 275703003: Make GN Android build link executables (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/android/config.gni ('K') | « tools/gn/escape.cc ('k') | tools/gn/target.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/settings.cc
diff --git a/tools/gn/settings.cc b/tools/gn/settings.cc
index 2715829998b71202624b3ba381d9b197f9d43c22..f39a0b3dd91798b14755215b282386bfa145804f 100644
--- a/tools/gn/settings.cc
+++ b/tools/gn/settings.cc
@@ -37,6 +37,10 @@ Settings::Settings(const BuildSettings* build_settings,
target_os_ = MAC;
#elif defined(OS_LINUX)
target_os_ = LINUX;
+#elif defined(OS_ANDROID)
+ // Currently we don't have an "Android" target OS, it looks just like Linux
+ // from our perspective.
+ target_os_ = LINUX;
#else
#error implement me
#endif
« build/config/android/config.gni ('K') | « tools/gn/escape.cc ('k') | tools/gn/target.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698