Make GN Android build link executables

build/config/compiler/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 if (cpu_arch == "arm") {
   import("//build/config/arm.gni")
 }
 
+declare_args() {
+  # Normally, Android builds are lightly optimized, even for debug builds, to
+  # keep binary size down. Setting this flag to true disables such optimization
+  android_full_debug = false
+}
+
 # compiler ---------------------------------------------------------------------
 #
 # Base compiler configuration.
 #
 # See also "runtime_library" below for related stuff and a discusison about
 # where stuff should go. Put warning related stuff in the "warnings" config.
 
 config("compiler") {
   cflags = []
   cflags_c = []
@@ skipping 32 matching lines @@
       # //build/config/gcc:symbol_visibility_hidden.
       "-fvisibility-inlines-hidden",
     ]
 
     # Stack protection.
     if (is_mac) {
       cflags += [ "-fstack-protector-all" ]
     } else if (is_linux) {
       cflags += [ "-fstack-protector", "--param=ssp-buffer-size=4" ]
     }
+
+    # Linker warnings.
+    if (!is_chromeos || cpu_arch != "arm") {
+      # TODO(jochen): Enable this on chromeos on arm. http://crbug.com/356580
+      ldflags += [ "-Wl,--fatal-warnings" ]
+    }
   }
 
   # Mac-specific compiler flags setup.
   # ----------------------------------
   if (is_mac || is_ios) {
     # These flags are shared between the C compiler and linker.
     common_mac_flags = []
 
     # CPU architecture.
     if (cpu_arch == "x64") {
@@ skipping 52 matching lines @@
     if (is_chrome_branded && is_official_build) {
       cflags += [
         "-fno-unwind-tables",
         "-fno-asynchronous-unwind-tables",
       ]
     } else {
       cflags += [ "-funwind-tables" ]
     }
   }
 
+  # Linux/Android common flags setup.
+  # ---------------------------------
+  if (is_linux || is_android) {
+    cflags += [
+      "-fPIC",
+      "-pipe",  # Use pipes for communicating between sub-processes. Faster.
+    ]
+
+    ldflags += [
+      "-fPIC",
+      "-Wl,-z,noexecstack",
+      "-Wl,-z,now",
+      "-Wl,-z,relro",
+    ]
+  }
+
   # Linux-specific compiler flags setup.
   # ------------------------------------
   if (is_linux) {
-    cflags += [
-      "-fPIC",
-      "-pipe",  # Use pipes for communicating between sub-processes. Faster.
-    ]
-    if (!is_android) {
-      cflags += [ "-pthread" ]
-    }
+    cflags += [ "-pthread" ]
 
     if (cpu_arch == "x64") {
       # Use gold for linking on 64-bit Linux only (on 32-bit it runs out of
       # address space, and it doesn't support cross-compiling).
       gold_path = rebase_path("//third_party/binutils/Linux_x64/Release/bin",
                               root_build_dir)
       ldflags += [
         "-B$gold_path",
 
         # There seems to be a conflict of --icf and -pie in gold which can
         # generate crashy binaries. As a security measure, -pie takes
         # precendence for now.
         # TODO(brettw) common.gypi has this only for target toolset.
         #"-Wl,--icf=safe",
         "-Wl,--icf=none",
 
         # Experimentation found that using four linking threads
         # saved ~20% of link time.
         # https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/281527606915bb36
         # Only apply this to the target linker, since the host
         # linker might not be gold, but isn't used much anyway.
         # TODO(raymes): Disable threading because gold is frequently
         # crashing on the bots: crbug.com/161942.
         #"-Wl,--threads",
         #"-Wl,--thread-count=4",
       ]
     }
 
     ldflags += [
-      "-fPIC",
       "-pthread",
-      "-Wl,-z,noexecstack",
-      "-Wl,-z,now",
-      "-Wl,-z,relro",
     ]
   }
 
   # Clang-specific compiler flags setup.
   # ------------------------------------
   if (is_clang) {
     cflags += [
       "-fcolor-diagnostics",
     ]
     cflags_cc += [
@@ skipping 30 matching lines @@
       cflags += [ "-mllvm -asan-globals=0" ]
     }
 
     defines += [ "ANDROID" ]
     if (!is_android_webview_build) {
       # The NDK has these things, but doesn't define the constants
       # to say that it does. Define them here instead.
       defines += [ "HAVE_SYS_UIO_H" ]
     }
 
+    # Use gold for Android for most CPU architectures.
+    if (cpu_arch == "x86" || cpu_arch == "x64" ||
+        (cpu_arch == "arm" && !is_clang)) {
+      # These architectures support gold for linking. Apparently Clang has not
+      # been made to work on x86 yet or we would probably need a -B option like
+      # we do below for Clang-on-arm.
+      ldflags += [ "-fuse-ld=gold" ]
+    } else if (cpu_arch == "arm") {
+      # Clang does not support -fuse-ld to invoke the built-in gold linker,
+      # so use the -B option which requires us to specify the path.
+      ldflags += [
+        "-B" + rebase_path("//build/android/arm-linux-androideabi-gold",
+                           root_build_dir)
+      ]
+    }
+
     ldflags += [
       "-Wl,--no-undefined",
       # Don't export symbols from statically linked libraries.
       "-Wl,--exclude-libs=ALL",
     ]
     if (cpu_arch == "arm") {
       ldflags += [
         # Enable identical code folding to reduce size.
         "-Wl,--icf=safe",
       ]
@@ skipping 77 matching lines @@
       ]
     }
 
     defines += [
       "USE_STLPORT=1",
       "_STLP_USE_PTR_SPECIALIZATIONS=1",
       "__GNU_SOURCE=1",  # Necessary for clone().
     ]
 
     ldflags += [
+      "-Wl,--warn-shared-textrel",
       "-nostdlib",
     ]
 
-
     # NOTE: The stlport header include paths below are specified in cflags
     # rather than include_dirs because they need to come after include_dirs.
     # Think of them like system headers, but don't use '-isystem' because the
     # arm-linux-androideabi-4.4.3 toolchain (circa Gingerbread) will exhibit
     # strange errors. The include ordering here is important; change with
     # caution.
     if (use_system_stlport) {
       cflags += [
         # For libstdc++/include, which is used by stlport.
-        "-I$android_src/bionic",
-        "-I$android_src/external/stlport/stlport",
+        "-I" + rebase_path("$android_src/bionic", root_build_dir),
+        "-I" + rebase_path("$android_src/external/stlport/stlport",
+                           root_build_dir),
       ]
       libs += [
         "stlport",
       ]
     } else {
       android_stlport_root = "$android_ndk_root/sources/cxx-stl/stlport"
 
-      cflags += [ "-I$android_stlport_root/stlport" ]
+      cflags += [
+        "-I" + rebase_path("$android_stlport_root/stlport", root_build_dir)
+      ]
       lib_dirs += [ "$android_stlport_root/libs/$android_app_abi" ]
 
       if (component_mode == "shared_library") {
         libs += [ "stlport_shared" ]
       } else {
         libs += [ "stlport_static" ]
       }
     }
+
+    libs += [
+      # Manually link the libgcc.a that the cross compiler uses. This is
+      # absolute because the linker will look inside the sysroot if it's not.
+      rebase_path(android_libgcc_file),
+      "c",
+      "dl",
+      "m",
+    ]
+
   }
 }
 
 # chromium_code ---------------------------------------------------------------
 #
 # Toggles between higher and lower warnings for code that is (or isn't)
 # part of Chromium.
 
 config("chromium_code") {
   if (is_win) {
@@ skipping 214 matching lines @@
 #
 # Note that BUILDCONFIG.gn sets up a variable "default_optimization_config"
 # which it will assign to the config it implicitly applies to every target. If
 # you want to override the optimization level for your target, remove this
 # config (which will expand differently for debug or release builds), and then
 # add back the one you want to override it with:
 #
 #   configs -= default_optimization_config
 #   configs += [ "//build/config/compiler/optimize_max" ]
 
-# Default "optimization on" config. On Windows, this favors size over speed.
-#
-# IF YOU CHANGE THIS also consider whether optimize_max should be updated.
-config("optimize") {
-  if (is_win) {
-    cflags = [
-      "/O2",
-      "/Ob2",  # Both explicit and auto inlining.
-      "/Oy-",  # Disable omitting frame pointers, must be after /O2.
-      "/Os",   # Favor size over speed.
+# Shared settings for both "optimize" and "optimize_max" configs.
+if (is_win) {
+  common_optimize_on_cflags = [

[scottmg, 2014/05/12 18:10:21]

more o->O here

+    "/o2",
+    "/ob2",  # both explicit and auto inlining.
+    "/oy-",  # disable omitting frame pointers, must be after /o2.
+    "/os",   # favor size over speed.
+  ]
+  common_optimize_on_ldflags = []
+} else {
+  common_optimize_on_cflags = [
+    # Don't emit the GCC version ident directives, they just end up in the
+    # .comment section taking up binary size.
+    "-fno-ident",
+    # Put data and code in their own sections, so that unused symbols
+    # can be removed at link time with --gc-sections.
+    "-fdata-sections",
+    "-ffunction-sections",
+  ]
+
+  common_optimize_on_ldflags = []
+  if (is_mac) {
+    if (symbol_level == 2) {
+      # Mac dead code stripping requires symbols.
+      common_optimize_on_ldflags += [
+        "-Wl,-dead_strip",
+      ]
+    }
+  } else {
+    # Non-Mac Posix linker flags.
+    common_optimize_on_ldflags += [
+      # Specifically tell the linker to perform optimizations.
+      # See http://lwn.net/Articles/192624/ .
+      "-Wl,-O1",
+      "-Wl,--as-needed",
+      "-Wl,--gc-sections",
     ]
+  }
+
+  if (is_ios) {
+    common_optimize_on_cflags += [ "-Os" ]

[cjhopman, 2014/05/12 18:37:17]

Android also uses -Os for release/optimized builds

   } else {
-    if (is_ios) {
-      cflags = [ "-Os" ]
-    } else {
-      cflags = [ "-O2" ]
-    }
+    common_optimize_on_cflags += [ "-O2" ]
   }
 }
 
+# Default "optimization on" config. On Windows, this favors size over speed.
+config("optimize") {
+  cflags = common_optimize_on_cflags
+  ldflags = common_optimize_on_ldflags
+  if (is_win) {
+    cflags += [
+      "/Os",   # favor size over speed.
+    ]
+  }
+}
+
 # Turn off optimizations.
 config("no_optimize") {
   if (is_win) {
     cflags = [
       "/Od",  # Disable optimization.
       "/Ob0",  # Disable all inlining (on by default).
       "/RTC1",  # Runtime checks for stack frame and uninitialized variables.
     ]
+  } else if (is_android && !android_full_debug) {
+    # On Android we kind of optimize some things that don't affect debugging
+    # much even when optimization is disabled to get the binary size down.
+    cflags = [
+      "-O1",

[cjhopman, 2014/05/12 18:37:17]

This is -Os in this case in common.gypi

+      "-fomit-frame-pointer",
+      "-fdata-sections",
+      "-ffunction-sections",
+    ]
+    ldflags = [
+      "-Wl,-O1",
+      "-Wl,--as-needed",
+      "-Wl,--gc-sections",
+    ]
   } else {
     cflags = [ "-O0" ]
   }
 }
 
 # On Windows, turns up the optimization level. This implies whole program
 # optimization and link-time code generation which is very expensive and should
 # be used sparingly. For non-Windows, this is the same as "optimize".
 config("optimize_max") {
+  cflags = common_optimize_on_cflags
+  ldflags = common_optimize_on_ldflags
   if (is_win) {
-    cflags = [
-      "/O2",
-      "/Ob2",  # Both explicit and auto inlining.
-      "/Oy-",  # Disable omitting frame pointers, must be after /O2.
+    cflags += [
       "/Ot",   # Favor speed over size.
       "/GL",   # Whole program optimization.
     ]
-  } else {
-    if (is_ios) {
-      cflags = [ "-Os" ]
-    } else {
-      cflags = [ "-O2" ]
-    }
   }
 }
 
 # Symbols ----------------------------------------------------------------------
 
-# TODO(brettw) Since this sets ldflags on Windows which is inherited across
-# static library boundaries, if you want to remove the default symbol config
-# and set a different one on a target, you also have to do it for all static
-# libraries that go into that target, which is messed up. Either we need a
-# more flexible system for defining linker flags, or we need to separate this
-# out into a "symbols_linker" config that is only applied to DLLs and EXEs.
 config("symbols") {
   if (is_win) {
     cflags = [ "/Zi" ]  # Produce PDB file, no edit and continue.
     ldflags = [ "/DEBUG" ]
   } else {
     cflags = [ "-g2" ]
   }
 }
 
 config("minimal_symbols") {
   if (is_win) {
     # Linker symbols for backtraces only.
     ldflags = [ "/DEBUG" ]
   } else {
     cflags = [ "-g1" ]
   }
 }
 
 config("no_symbols") {
   if (!is_win) {
     cflags = [ "-g0" ]
   }
 }