Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2756953002: Update parser documentation. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove redundant 'all'. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -80 lines) Patch
M pkg/front_end/lib/src/fasta/parser/parser.dart View 1 11 chunks +76 lines, -80 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
ahe
3 years, 9 months ago (2017-03-17 17:11:37 UTC) #3
ahe
Karl, could you take a look? Johnni is OOO.
3 years, 9 months ago (2017-03-22 08:30:41 UTC) #5
karlklose
LGTM https://codereview.chromium.org/2756953002/diff/20001/pkg/front_end/lib/src/fasta/parser/parser.dart File pkg/front_end/lib/src/fasta/parser/parser.dart (right): https://codereview.chromium.org/2756953002/diff/20001/pkg/front_end/lib/src/fasta/parser/parser.dart#newcode119 pkg/front_end/lib/src/fasta/parser/parser.dart:119: /// The parser assumes that all keywords, built-in ...
3 years, 9 months ago (2017-03-22 08:49:09 UTC) #6
ahe
Thank you, Karl! https://codereview.chromium.org/2756953002/diff/20001/pkg/front_end/lib/src/fasta/parser/parser.dart File pkg/front_end/lib/src/fasta/parser/parser.dart (right): https://codereview.chromium.org/2756953002/diff/20001/pkg/front_end/lib/src/fasta/parser/parser.dart#newcode119 pkg/front_end/lib/src/fasta/parser/parser.dart:119: /// The parser assumes that all ...
3 years, 9 months ago (2017-03-22 11:17:17 UTC) #7
ahe
3 years, 9 months ago (2017-03-22 11:17:48 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
3de706a0ec3d5a4b1fb9ef6752b703e020c16de1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698