Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issue 275693003: Use the scale factor in the image in the DrawImageIntHelper function in case we are not drawing in … (Closed)

Created:
6 years, 7 months ago by ananta
Modified:
6 years, 7 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews
Visibility:
Public.

Description

Use the scale factor in the image in the DrawImageIntHelper function in case we are not drawing in pixels. BUG=370392 R=oshima Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269818

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/gfx/canvas.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
ananta
oshima, please test this patch. Thanks Ananta
6 years, 7 months ago (2014-05-09 01:42:23 UTC) #1
oshima
lgtm yep, this works and also confirmed that this was the difference in https://codereview.chromium.org/262773010
6 years, 7 months ago (2014-05-09 16:23:02 UTC) #2
ananta
The CQ bit was checked by ananta@chromium.org
6 years, 7 months ago (2014-05-09 18:02:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/275693003/1
6 years, 7 months ago (2014-05-09 18:05:38 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 18:39:25 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-09 18:56:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/66868)
6 years, 7 months ago (2014-05-09 18:56:14 UTC) #7
sky
LGTM
6 years, 7 months ago (2014-05-09 22:36:12 UTC) #8
ananta
The CQ bit was checked by ananta@chromium.org
6 years, 7 months ago (2014-05-12 18:05:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/275693003/1
6 years, 7 months ago (2014-05-12 18:06:01 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 18:13:17 UTC) #11
Message was sent while issue was closed.
Change committed as 269818

Powered by Google App Engine
This is Rietveld 408576698