content/browser/renderer_host/render_widget_host_view_event_handler.cc - Issue 2756893002: Add Keyboard Latency UMA Metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_event_handler.cc

Issue 2756893002: Add Keyboard Latency UMA Metrics. (Closed)

Patch Set: Restrict to RawKeyDown and Char events on Android & Mac Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_event_handler.h ('k') | content/browser/renderer_host/render_widget_host_view_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_event_handler.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_event_handler.cc b/content/browser/renderer_host/render_widget_host_view_event_handler.cc

index 980a6780b411c34b8988b6bb93bf7d1c3dd833a0..bccea9a39c0d489eb7892b5e03a28c3cfe51648b 100644

--- a/content/browser/renderer_host/render_widget_host_view_event_handler.cc

+++ b/content/browser/renderer_host/render_widget_host_view_event_handler.cc

@@ -284,7 +284,8 @@ void RenderWidgetHostViewEventHandler::OnKeyEvent(ui::KeyEvent* event) {

SetKeyboardFocus();

// We don't have to communicate with an input method here.

NativeWebKeyboardEvent webkit_event(*event);

- delegate_->ForwardKeyboardEvent(webkit_event, &mark_event_as_handled);

+ delegate_->ForwardKeyboardEventWithLatencyInfo(

+ webkit_event, *event->latency(), &mark_event_as_handled);

}

if (mark_event_as_handled)

event->SetHandled();