Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1383)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 2756893002: Add Keyboard Latency UMA Metrics. (Closed)
Patch Set: mfomitchev responses, rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index 8631b0cba3ece9b0d71a2ec2b9cbe876ce0593f7..dd2bb4b64d10bb7d280a409a7fe5dea1f6860a2f 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -1042,8 +1042,8 @@ void RenderWidgetHostImpl::ForwardMouseEvent(const WebMouseEvent& mouse_event) {
}
void RenderWidgetHostImpl::ForwardMouseEventWithLatencyInfo(
- const blink::WebMouseEvent& mouse_event,
- const ui::LatencyInfo& ui_latency) {
+ const blink::WebMouseEvent& mouse_event,
+ const ui::LatencyInfo& latency) {
TRACE_EVENT2("input", "RenderWidgetHostImpl::ForwardMouseEvent", "x",
mouse_event.PositionInWidget().x, "y",
mouse_event.PositionInWidget().y);
@@ -1059,7 +1059,7 @@ void RenderWidgetHostImpl::ForwardMouseEventWithLatencyInfo(
if (touch_emulator_ && touch_emulator_->HandleMouseEvent(mouse_event))
return;
- MouseEventWithLatencyInfo mouse_with_latency(mouse_event, ui_latency);
+ MouseEventWithLatencyInfo mouse_with_latency(mouse_event, latency);
DispatchInputEventWithLatencyInfo(mouse_event, &mouse_with_latency.latency);
input_router_->SendMouseEvent(mouse_with_latency);
}
@@ -1071,8 +1071,8 @@ void RenderWidgetHostImpl::ForwardWheelEvent(
}
void RenderWidgetHostImpl::ForwardWheelEventWithLatencyInfo(
- const blink::WebMouseWheelEvent& wheel_event,
- const ui::LatencyInfo& ui_latency) {
+ const blink::WebMouseWheelEvent& wheel_event,
+ const ui::LatencyInfo& latency) {
TRACE_EVENT2("input", "RenderWidgetHostImpl::ForwardWheelEvent", "dx",
wheel_event.delta_x, "dy", wheel_event.delta_y);
@@ -1082,7 +1082,7 @@ void RenderWidgetHostImpl::ForwardWheelEventWithLatencyInfo(
if (touch_emulator_ && touch_emulator_->HandleMouseWheelEvent(wheel_event))
return;
- MouseWheelEventWithLatencyInfo wheel_with_latency(wheel_event, ui_latency);
+ MouseWheelEventWithLatencyInfo wheel_with_latency(wheel_event, latency);
DispatchInputEventWithLatencyInfo(wheel_event, &wheel_with_latency.latency);
input_router_->SendWheelEvent(wheel_with_latency);
}
@@ -1102,7 +1102,7 @@ void RenderWidgetHostImpl::ForwardGestureEvent(
void RenderWidgetHostImpl::ForwardGestureEventWithLatencyInfo(
const blink::WebGestureEvent& gesture_event,
- const ui::LatencyInfo& ui_latency) {
+ const ui::LatencyInfo& latency) {
TRACE_EVENT0("input", "RenderWidgetHostImpl::ForwardGestureEvent");
// Early out if necessary, prior to performing latency logic.
if (ShouldDropInputEvents())
@@ -1153,7 +1153,7 @@ void RenderWidgetHostImpl::ForwardGestureEventWithLatencyInfo(
if (delegate_->PreHandleGestureEvent(gesture_event))
return;
- GestureEventWithLatencyInfo gesture_with_latency(gesture_event, ui_latency);
+ GestureEventWithLatencyInfo gesture_with_latency(gesture_event, latency);
DispatchInputEventWithLatencyInfo(gesture_event,
&gesture_with_latency.latency);
input_router_->SendGestureEvent(gesture_with_latency);
@@ -1176,14 +1176,14 @@ void RenderWidgetHostImpl::ForwardEmulatedTouchEvent(
}
void RenderWidgetHostImpl::ForwardTouchEventWithLatencyInfo(
- const blink::WebTouchEvent& touch_event,
- const ui::LatencyInfo& ui_latency) {
+ const blink::WebTouchEvent& touch_event,
+ const ui::LatencyInfo& latency) {
TRACE_EVENT0("input", "RenderWidgetHostImpl::ForwardTouchEvent");
// Always forward TouchEvents for touch stream consistency. They will be
// ignored if appropriate in FilterInputEvent().
- TouchEventWithLatencyInfo touch_with_latency(touch_event, ui_latency);
+ TouchEventWithLatencyInfo touch_with_latency(touch_event, latency);
if (touch_emulator_ &&
touch_emulator_->HandleTouchEvent(touch_with_latency.event)) {
if (view_) {
@@ -1197,13 +1197,15 @@ void RenderWidgetHostImpl::ForwardTouchEventWithLatencyInfo(
input_router_->SendTouchEvent(touch_with_latency);
}
-void RenderWidgetHostImpl::ForwardKeyboardEvent(
- const NativeWebKeyboardEvent& key_event) {
- ForwardKeyboardEventWithCommands(key_event, nullptr, nullptr);
+void RenderWidgetHostImpl::ForwardKeyboardEventWithLatencyInfo(
+ const NativeWebKeyboardEvent& key_event,
+ const ui::LatencyInfo& latency) {
+ ForwardKeyboardEventWithCommands(key_event, latency, nullptr, nullptr);
}
void RenderWidgetHostImpl::ForwardKeyboardEventWithCommands(
const NativeWebKeyboardEvent& key_event,
+ const ui::LatencyInfo& latency,
const std::vector<EditCommand>* commands,
bool* update_event) {
TRACE_EVENT0("input", "RenderWidgetHostImpl::ForwardKeyboardEvent");
@@ -1280,9 +1282,8 @@ void RenderWidgetHostImpl::ForwardKeyboardEventWithCommands(
if (touch_emulator_ && touch_emulator_->HandleKeyboardEvent(key_event))
return;
- ui::LatencyInfo latency_info(ui::SourceEventType::OTHER);
NativeWebKeyboardEventWithLatencyInfo key_event_with_latency(key_event,
- latency_info);
+ latency);
key_event_with_latency.event.is_browser_shortcut = is_shortcut;
DispatchInputEventWithLatencyInfo(key_event, &key_event_with_latency.latency);
// TODO(foolip): |InputRouter::SendKeyboardEvent()| may filter events, in

Powered by Google App Engine
This is Rietveld 408576698