Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Unified Diff: chrome/browser/autofill/autofill_interactive_uitest.cc

Issue 2756893002: Add Keyboard Latency UMA Metrics. (Closed)
Patch Set: mfomitchev responses, rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autofill_interactive_uitest.cc
diff --git a/chrome/browser/autofill/autofill_interactive_uitest.cc b/chrome/browser/autofill/autofill_interactive_uitest.cc
index cd67195ee1d913c3f0b79eb84e0632611a4cf2ee..f9fd93b988d4bdafcc5cd09aff5fcf40643325a7 100644
--- a/chrome/browser/autofill/autofill_interactive_uitest.cc
+++ b/chrome/browser/autofill/autofill_interactive_uitest.cc
@@ -484,7 +484,7 @@ class AutofillInteractiveTest : public InProcessBrowserTest {
// Install the key press event sink to ensure that any events that are not
// handled by the installed callbacks do not end up crashing the test.
widget->AddKeyPressEventCallback(key_press_event_sink_);
- widget->ForwardKeyboardEvent(event);
+ widget->ForwardKeyboardEventWithLatencyInfo(event, ui::LatencyInfo());
test_delegate_.Wait();
widget->RemoveKeyPressEventCallback(key_press_event_sink_);
}
@@ -511,7 +511,8 @@ class AutofillInteractiveTest : public InProcessBrowserTest {
// handled by the installed callbacks do not end up crashing the test.
GetRenderViewHost()->GetWidget()->AddKeyPressEventCallback(
key_press_event_sink_);
- GetRenderViewHost()->GetWidget()->ForwardKeyboardEvent(event);
+ GetRenderViewHost()->GetWidget()->ForwardKeyboardEventWithLatencyInfo(
+ event, ui::LatencyInfo());
GetRenderViewHost()->GetWidget()->RemoveKeyPressEventCallback(
key_press_event_sink_);
}

Powered by Google App Engine
This is Rietveld 408576698