chrome/browser/chromeos/accessibility/event_handler_common.cc - Issue 2756893002: Add Keyboard Latency UMA Metrics.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/chromeos/accessibility/event_handler_common.cc

Issue 2756893002: Add Keyboard Latency UMA Metrics. (Closed)

Patch Set: Fix test issue Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff |

« no previous file with comments | « chrome/browser/autofill/autofill_interactive_uitest.cc ('k') | chrome/browser/password_manager/password_generation_interactive_uitest.cc » ('j') | chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/chromeos/accessibility/event_handler_common.h"	5 #include "chrome/browser/chromeos/accessibility/event_handler_common.h"

6	6

7 #include "chrome/browser/chromeos/accessibility/accessibility_manager.h"	7 #include "chrome/browser/chromeos/accessibility/accessibility_manager.h"

8 #include "chrome/browser/profiles/profile_manager.h"	8 #include "chrome/browser/profiles/profile_manager.h"

9 #include "content/public/browser/render_view_host.h"	9 #include "content/public/browser/render_view_host.h"

10 #include "content/public/browser/render_widget_host.h"	10 #include "content/public/browser/render_widget_host.h"

(...skipping 31 matching lines...) Loading...
42 return;	42 return;

43 }	43 }

44	44

45 content::RenderViewHost* rvh = host->render_view_host();	45 content::RenderViewHost* rvh = host->render_view_host();

46 if (!rvh) {	46 if (!rvh) {

47 LOG(ERROR) << "Unable to forward key to extension";	47 LOG(ERROR) << "Unable to forward key to extension";

48 return;	48 return;

49 }	49 }

50	50

51 const content::NativeWebKeyboardEvent web_event(key_event);	51 const content::NativeWebKeyboardEvent web_event(key_event);

52 rvh->GetWidget()->ForwardKeyboardEvent(web_event);	52 rvh->GetWidget()->ForwardKeyboardEventWithLatencyInfo(web_event,

	53 ui::LatencyInfo());
	mfomitchev 2017/04/04 14:59:05 wouldn't we want to take latency() from key_event? wouldn't we want to take latency() from key_event? tdresser 2017/05/01 15:49:21 Oops. Done. Show quoted text On 2017/04/04 14:59:05, mfomitchev wrote: > wouldn't we want to take latency() from key_event? Oops. Done.
53 }	54 }

54 } // namespace chromeos	55 } // namespace chromeos

OLD	NEW