chrome/browser/resources/chromeos/login/oobe_reset.css - Issue 2756863002: ChromeOS: Powerwash UI update

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/chromeos/login/oobe_reset.css

Issue 2756863002: ChromeOS: Powerwash UI update (Closed)

Patch Set: Use String to denote UI state Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/login/oobe_buttons.js ('k') | chrome/browser/resources/chromeos/login/oobe_reset.html » ('j') | chrome/browser/resources/chromeos/login/oobe_reset.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 /* Copyright 2017 The Chromium Authors. All rights reserved.

	2 * Use of this source code is governed by a BSD-style license that can be

	3 * found in the LICENSE file. */

	4

	5 #reset-illustration {

	6 height: 248px;
	Alexander Alekseev 2017/04/08 10:36:18 We don't need hardcoded value of pixel image size. We don't need hardcoded value of pixel image size. Wenzhao (Colin) Zang 2017/04/10 20:37:35 It's removed. Show quoted text On 2017/04/08 10:36:18, Alexander Alekseev wrote: > We don't need hardcoded value of pixel image size. It's removed.
	7 padding: 50px 40px;
	Alexander Alekseev 2017/04/08 10:36:18 Why? Could you just center it vertically? Why? Could you just center it vertically? Wenzhao (Colin) Zang 2017/04/10 20:37:35 Because the illustration is not symmetric, with mo Show quoted text On 2017/04/08 10:36:18, Alexander Alekseev wrote: > Why? > Could you just center it vertically? Because the illustration is not symmetric, with more white space on the right. In order to make it look 'centered', I think it's better to have more padding on the left. Please see: https://drive.google.com/a/google.com/file/d/0B_2Uyb2Rhx2OSmlRUEE4U18wemc/vie...
	8 }

	9

	10 .vertical-margin {

	11 width: 22px;

	12 }

	13

	14 #reset-revert-spinner-message-md {

	15 display: inline-block;

	16 padding: 25px 0;

	17 vertical-align: middle;
	Alexander Alekseev 2017/04/08 10:36:18 Could you do this with polymer class styling? Could you do this with polymer class styling? Wenzhao (Colin) Zang 2017/04/10 20:37:35 Sorry I don't get it, could you please explain on Show quoted text On 2017/04/08 10:36:18, Alexander Alekseev wrote: > Could you do this with polymer class styling? Sorry I don't get it, could you please explain on this? Is it the same with CSS class binding, like: 'class$="[[]]"', then do we need it if the class name doesn't change?
	18 }

	19

	20 #reset-revert-spinner-md {

	21 margin-top: 0;

	22 vertical-align: middle;

	23 }

OLD	NEW