ChromeOS: Powerwash UI update

chrome/browser/resources/chromeos/login/oobe_reset.js

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+/**
+ * @fileoverview Polymer element for displaying material design reset screen.
+ */
+
+Polymer({
+  is: 'oobe-reset-md',
+
+  properties: {
+    /**
+     * State of the screen corresponding to the css style set by
+     * oobe_screen_reset.js.
+     *
+     * 1 - 'restart-required-view',
+     * 2 - 'powerwash-proposal-view',
+     * 4 - 'rollback-proposal-view',

[jdufault, 2017/04/06 01:04:52]

Use separate variables instead of trying to encode all state via flags.

Encoding via flags like this is generally harder to understand because
'uiState_' does not provide any semantic value to the reader. For example,
getHidden_(*, 2) has no immediate meaning - compare to
isPowerwashProposalHidden().

Using a constant for 2 helps, getHidden(*, POWERWASH_PROPOSAL), but the
underlying implementation is still hiding additional complexity that isn't
needed.

There's probably an argument for code deduplication, but there's already a
method isHelpLinkHidden_, which makes the reader question the difference between
getHidden_ and isHelpLinkHidden_.

[Wenzhao (Colin) Zang, 2017/04/07 02:55:36]

Done.

+     * 8 - 'revert-promise-view',
+     * 0 - no state has been specified yet.
+     */
+    uiState_: {
+      type: Number,
+      value: 0,
+    },
+
+    isOfficial_: Boolean,
+  },
+
+  getHidden_: function(uiState_, current) {
+    return !(uiState_ & current);
+  },
+
+  isHelpLinkHidden_: function(uiState_, isOfficial_) {
+    return !isOfficial_ || (uiState_ == 8);
+  },
+
+  /**
+   * On-tap event handler for cancel button.
+   */
+  onCancelClicked_: function() {
+    chrome.send('login.ResetScreen.userActed', ['cancel-reset']);
+  },
+
+  /**
+   * On-tap event handler for restart button.
+   */
+  onRestartClicked_: function() {
+    chrome.send('login.ResetScreen.userActed', ['restart-pressed']);
+  },
+
+  /**
+   * On-tap event handler for powerwash button.
+   */
+  onPowerwashClicked_: function() {
+    chrome.send('login.ResetScreen.userActed', ['show-confirmation']);
+  },
+
+  /**
+   * On-tap event handler for learn more link.
+   */
+  onLearnMoreClicked_: function() {
+    chrome.send('login.ResetScreen.userActed', ['learn-more-link']);
+  },
+});