Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java

Issue 2756813002: Refactor ContentViewClient (5/6) (Closed)
Patch Set: fix bug/tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
index 6ef25210eb34f121912dd3fca773329eb31fc187..1acc2871977fb0e13e8597e732cefa271d5157f3 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
@@ -4,8 +4,6 @@
package org.chromium.content.browser;
-import android.view.KeyEvent;
-
/**
* Main callback class used by ContentView.
*
@@ -31,41 +29,6 @@ public class ContentViewClient {
public void onFocusedNodeEditabilityChanged(boolean editable) {}
/**
- * Check whether a key should be propagated to the embedder or not.
- * We need to send almost every key to Blink. However:
- * 1. We don't want to block the device on the renderer for
- * some keys like menu, home, call.
- * 2. There are no WebKit equivalents for some of these keys
- * (see app/keyboard_codes_win.h)
- * Note that these are not the same set as KeyEvent.isSystemKey:
- * for instance, AKEYCODE_MEDIA_* will be dispatched to webkit*.
- */
- public static boolean shouldPropagateKey(int keyCode) {
- if (keyCode == KeyEvent.KEYCODE_MENU
- || keyCode == KeyEvent.KEYCODE_HOME
- || keyCode == KeyEvent.KEYCODE_BACK
- || keyCode == KeyEvent.KEYCODE_CALL
- || keyCode == KeyEvent.KEYCODE_ENDCALL
- || keyCode == KeyEvent.KEYCODE_POWER
- || keyCode == KeyEvent.KEYCODE_HEADSETHOOK
- || keyCode == KeyEvent.KEYCODE_CAMERA
- || keyCode == KeyEvent.KEYCODE_FOCUS
- || keyCode == KeyEvent.KEYCODE_VOLUME_DOWN
- || keyCode == KeyEvent.KEYCODE_VOLUME_MUTE
- || keyCode == KeyEvent.KEYCODE_VOLUME_UP) {
- return false;
- }
- return true;
- }
-
- /**
- * @see {@link #shouldPropagateKey(int)
- */
- public boolean shouldOverrideKeyEvent(KeyEvent event) {
- return !shouldPropagateKey(event.getKeyCode());
- }
-
- /**
* Returns the bottom system window inset in pixels. The system window inset represents the area
* of a full-screen window that is partially or fully obscured by the status bar, navigation
* bar, IME or other system windows.

Powered by Google App Engine
This is Rietveld 408576698