Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: gpu/config/gpu_driver_bug_list.h

Issue 2756793003: Move GPU blacklist and driver bug workaround list from json to data struct. (Closed)
Patch Set: pure rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/config/gpu_control_list_version_unittest.cc ('k') | gpu/config/gpu_driver_bug_list.README » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/config/gpu_driver_bug_list.h
diff --git a/gpu/config/gpu_driver_bug_list.h b/gpu/config/gpu_driver_bug_list.h
index 0ec839ed4eecafe17b2d88d140e0352b30e4c9ef..c30a019d87e0c10e5cce0880019be236291d1571 100644
--- a/gpu/config/gpu_driver_bug_list.h
+++ b/gpu/config/gpu_driver_bug_list.h
@@ -5,13 +5,12 @@
#ifndef GPU_CONFIG_GPU_DRIVER_BUG_LIST_H_
#define GPU_CONFIG_GPU_DRIVER_BUG_LIST_H_
+#include <memory>
#include <set>
-#include <string>
#include "base/command_line.h"
#include "base/macros.h"
#include "gpu/config/gpu_control_list.h"
-#include "gpu/config/gpu_driver_bug_workaround_type.h"
#include "gpu/gpu_export.h"
namespace gpu {
@@ -20,7 +19,9 @@ class GPU_EXPORT GpuDriverBugList : public GpuControlList {
public:
~GpuDriverBugList() override;
- static GpuDriverBugList* Create();
+ static std::unique_ptr<GpuDriverBugList> Create();
+ static std::unique_ptr<GpuDriverBugList> Create(
+ const GpuControlListData& data);
// Append |workarounds| with these passed in through the
// |command_line|.
@@ -34,7 +35,7 @@ class GPU_EXPORT GpuDriverBugList : public GpuControlList {
static void AppendAllWorkarounds(std::vector<const char*>* workarounds);
private:
- GpuDriverBugList();
+ explicit GpuDriverBugList(const GpuControlListData& data);
DISALLOW_COPY_AND_ASSIGN(GpuDriverBugList);
};
@@ -42,4 +43,3 @@ class GPU_EXPORT GpuDriverBugList : public GpuControlList {
} // namespace gpu
#endif // GPU_CONFIG_GPU_DRIVER_BUG_LIST_H_
-
« no previous file with comments | « gpu/config/gpu_control_list_version_unittest.cc ('k') | gpu/config/gpu_driver_bug_list.README » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698