Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: gpu/config/gpu_control_list_os_info_unittest.cc

Issue 2756793003: Move GPU blacklist and driver bug workaround list from json to data struct. (Closed)
Patch Set: pure rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/config/gpu_control_list_number_info_unittest.cc ('k') | gpu/config/gpu_control_list_testing.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/config/gpu_control_list_os_info_unittest.cc
diff --git a/gpu/config/gpu_control_list_os_info_unittest.cc b/gpu/config/gpu_control_list_os_info_unittest.cc
deleted file mode 100644
index 510487c4dea55093abd95f18b034aad57329cfcf..0000000000000000000000000000000000000000
--- a/gpu/config/gpu_control_list_os_info_unittest.cc
+++ /dev/null
@@ -1,153 +0,0 @@
-// Copyright (c) 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include <stddef.h>
-
-#include "gpu/config/gpu_control_list.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace gpu {
-
-class OsInfoTest : public testing::Test {
- public:
- OsInfoTest() { }
- ~OsInfoTest() override {}
-
- typedef GpuControlList::OsInfo OsInfo;
-};
-
-TEST_F(OsInfoTest, ValidOsInfo) {
- const std::string os[] = {
- "win",
- "linux",
- "macosx",
- "chromeos",
- "android",
- "any"
- };
- const GpuControlList::OsType os_type[] = {
- GpuControlList::kOsWin,
- GpuControlList::kOsLinux,
- GpuControlList::kOsMacosx,
- GpuControlList::kOsChromeOS,
- GpuControlList::kOsAndroid,
- GpuControlList::kOsAny
- };
- for (size_t i = 0; i < arraysize(os); ++i) {
- OsInfo info(os[i], "=", "10.6", std::string());
- EXPECT_TRUE(info.IsValid());
- EXPECT_EQ(os_type[i], info.type());
- }
- {
- OsInfo info("any", "any", std::string(), std::string());
- EXPECT_TRUE(info.IsValid());
- }
-}
-
-TEST_F(OsInfoTest, InvalidOsInfo) {
- const std::string os[] = {
- "win",
- "linux",
- "macosx",
- "chromeos",
- "android",
- "any"
- };
- for (size_t i = 0; i < arraysize(os); ++i) {
- {
- OsInfo info(os[i], std::string(), std::string(), std::string());
- EXPECT_FALSE(info.IsValid());
- }
- {
- OsInfo info(os[i], "=", std::string(), std::string());
- EXPECT_FALSE(info.IsValid());
- }
- {
- OsInfo info(os[i], std::string(), "10.6", std::string());
- EXPECT_FALSE(info.IsValid());
- }
- }
- const std::string os_cap[] = {
- "Win",
- "Linux",
- "MacOSX",
- "ChromeOS",
- "Android",
- };
- for (size_t i = 0; i < arraysize(os_cap); ++i) {
- OsInfo info(os_cap[i], "=", "10.6", std::string());
- EXPECT_FALSE(info.IsValid());
- }
-}
-
-TEST_F(OsInfoTest, NonNumericOsVersion) {
- {
- OsInfo info("android", "<", "4.2", std::string());
- EXPECT_TRUE(info.IsValid());
- // The expectation is the version number first, then extra info.
- EXPECT_TRUE(info.Contains(
- GpuControlList::kOsAndroid, "4.0 bug fix version 5.2"));
- EXPECT_FALSE(info.Contains(GpuControlList::kOsAndroid, "F"));
- EXPECT_FALSE(info.Contains(GpuControlList::kOsAndroid, "F 4.0"));
- EXPECT_FALSE(info.Contains(GpuControlList::kOsAndroid, std::string()));
- }
- {
- OsInfo info("android", "any", std::string(), std::string());
- EXPECT_TRUE(info.IsValid());
- EXPECT_TRUE(info.Contains(
- GpuControlList::kOsAndroid, "4.0 bug fix version 5.2"));
- EXPECT_TRUE(info.Contains(GpuControlList::kOsAndroid, "F"));
- EXPECT_TRUE(info.Contains(GpuControlList::kOsAndroid, "F 4.0"));
- EXPECT_TRUE(info.Contains(GpuControlList::kOsAndroid, std::string()));
- }
-}
-
-TEST_F(OsInfoTest, OsVersionZero) {
- {
- OsInfo info("android", "<", "4.2", std::string());
- EXPECT_TRUE(info.IsValid());
- // All forms of version 0 is considered invalid.
- EXPECT_FALSE(info.Contains(GpuControlList::kOsAndroid, "0"));
- EXPECT_FALSE(info.Contains(GpuControlList::kOsAndroid, "0.0"));
- EXPECT_FALSE(info.Contains(GpuControlList::kOsAndroid, "0.00.0"));
- }
- {
- OsInfo info("android", "any", std::string(), std::string());
- EXPECT_TRUE(info.IsValid());
- EXPECT_TRUE(info.Contains(GpuControlList::kOsAndroid, "0"));
- EXPECT_TRUE(info.Contains(GpuControlList::kOsAndroid, "0.0"));
- EXPECT_TRUE(info.Contains(GpuControlList::kOsAndroid, "0.00.0"));
- }
-}
-
-TEST_F(OsInfoTest, OsComparison) {
- {
- OsInfo info("any", "any", std::string(), std::string());
- const GpuControlList::OsType os_type[] = {
- GpuControlList::kOsWin, GpuControlList::kOsLinux,
- GpuControlList::kOsMacosx, GpuControlList::kOsChromeOS,
- GpuControlList::kOsAndroid,
- };
- for (size_t i = 0; i < arraysize(os_type); ++i) {
- EXPECT_TRUE(info.Contains(os_type[i], std::string()));
- EXPECT_TRUE(info.Contains(os_type[i], "7.8"));
- }
- }
- {
- OsInfo info("win", ">=", "6", std::string());
- EXPECT_FALSE(info.Contains(GpuControlList::kOsMacosx, "10.8.3"));
- EXPECT_FALSE(info.Contains(GpuControlList::kOsLinux, "10"));
- EXPECT_FALSE(info.Contains(GpuControlList::kOsChromeOS, "13"));
- EXPECT_FALSE(info.Contains(GpuControlList::kOsAndroid, "7"));
- EXPECT_FALSE(info.Contains(GpuControlList::kOsAny, "7"));
- EXPECT_FALSE(info.Contains(GpuControlList::kOsWin, std::string()));
- EXPECT_TRUE(info.Contains(GpuControlList::kOsWin, "6"));
- EXPECT_TRUE(info.Contains(GpuControlList::kOsWin, "6.1"));
- EXPECT_TRUE(info.Contains(GpuControlList::kOsWin, "7"));
- EXPECT_FALSE(info.Contains(GpuControlList::kOsWin, "5"));
- }
-}
-
-} // namespace gpu
-
« no previous file with comments | « gpu/config/gpu_control_list_number_info_unittest.cc ('k') | gpu/config/gpu_control_list_testing.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698