Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2017)

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 2756793003: Move GPU blacklist and driver bug workaround list from json to data struct. (Closed)
Patch Set: pure rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service_unittest.cc
diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc
index 4820fbea3a2162d0590202d390b58dd6b37fd442..f1213f1c68c356845e73da63376b412d82720d88 100644
--- a/chrome/browser/extensions/extension_service_unittest.cc
+++ b/chrome/browser/extensions/extension_service_unittest.cc
@@ -128,7 +128,6 @@
#include "extensions/common/switches.h"
#include "extensions/common/url_pattern.h"
#include "extensions/common/value_builder.h"
-#include "gpu/config/gpu_info.h"
#include "net/cookies/cookie_options.h"
#include "net/cookies/cookie_store.h"
#include "net/url_request/url_request_context.h"
@@ -638,23 +637,6 @@ class ExtensionServiceTest
void TestExternalProvider(MockExtensionProvider* provider,
Manifest::Location location);
- void BlackListWebGL() {
- static const std::string json_blacklist =
- "{\n"
- " \"name\": \"gpu blacklist\",\n"
- " \"version\": \"1.0\",\n"
- " \"entries\": [\n"
- " {\n"
- " \"id\": 1,\n"
- " \"features\": [\"accelerated_webgl\"]\n"
- " }\n"
- " ]\n"
- "}";
- gpu::GPUInfo gpu_info;
- content::GpuDataManager::GetInstance()->InitializeForTesting(
- json_blacklist, gpu_info);
- }
-
// Grants all optional permissions stated in manifest to active permission
// set for extension |id|.
void GrantAllOptionalPermissions(const std::string& id) {
@@ -4567,7 +4549,7 @@ TEST_F(ExtensionServiceTest, UninstallExtensionHelperTerminated) {
// other disable reasons.
TEST_F(ExtensionServiceTest, UpgradingRequirementsEnabled) {
InitializeEmptyExtensionService();
- BlackListWebGL();
+ content::GpuDataManager::GetInstance()->BlacklistWebGLForTesting();
base::FilePath path = data_dir().AppendASCII("requirements");
base::FilePath pem_path =
@@ -4596,7 +4578,7 @@ TEST_F(ExtensionServiceTest, UpgradingRequirementsEnabled) {
// Extensions disabled through user action should stay disabled.
TEST_F(ExtensionServiceTest, UpgradingRequirementsDisabled) {
InitializeEmptyExtensionService();
- BlackListWebGL();
+ content::GpuDataManager::GetInstance()->BlacklistWebGLForTesting();
base::FilePath path = data_dir().AppendASCII("requirements");
base::FilePath pem_path =
@@ -4627,7 +4609,7 @@ TEST_F(ExtensionServiceTest, UpgradingRequirementsDisabled) {
// permission increase.
TEST_F(ExtensionServiceTest, UpgradingRequirementsPermissions) {
InitializeEmptyExtensionService();
- BlackListWebGL();
+ content::GpuDataManager::GetInstance()->BlacklistWebGLForTesting();
base::FilePath path = data_dir().AppendASCII("requirements");
base::FilePath pem_path =
@@ -4659,7 +4641,7 @@ TEST_F(ExtensionServiceTest, UpgradingRequirementsPermissions) {
// requirements.
TEST_F(ExtensionServiceTest, UnpackedRequirements) {
InitializeEmptyExtensionService();
- BlackListWebGL();
+ content::GpuDataManager::GetInstance()->BlacklistWebGLForTesting();
base::FilePath path =
data_dir().AppendASCII("requirements").AppendASCII("v2_bad_requirements");

Powered by Google App Engine
This is Rietveld 408576698