Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: gpu/config/gpu_driver_bug_list.h

Issue 2756793003: Move GPU blacklist and driver bug workaround list from json to data struct. (Closed)
Patch Set: Switch to use arraysize Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GPU_CONFIG_GPU_DRIVER_BUG_LIST_H_ 5 #ifndef GPU_CONFIG_GPU_DRIVER_BUG_LIST_H_
6 #define GPU_CONFIG_GPU_DRIVER_BUG_LIST_H_ 6 #define GPU_CONFIG_GPU_DRIVER_BUG_LIST_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 10
11 #include "base/command_line.h" 11 #include "base/command_line.h"
12 #include "base/macros.h" 12 #include "base/macros.h"
13 #include "gpu/config/gpu_control_list.h" 13 #include "gpu/config/gpu_control_list.h"
14 #include "gpu/config/gpu_driver_bug_workaround_type.h" 14 #include "gpu/config/gpu_driver_bug_workaround_type.h"
15 #include "gpu/gpu_export.h" 15 #include "gpu/gpu_export.h"
16 16
17 namespace gpu { 17 namespace gpu {
18 18
19 class GPU_EXPORT GpuDriverBugList : public GpuControlList { 19 class GPU_EXPORT GpuDriverBugList : public GpuControlList {
20 public: 20 public:
21 ~GpuDriverBugList() override; 21 ~GpuDriverBugList() override;
22 22
23 static GpuDriverBugList* Create(); 23 static GpuDriverBugList* Create();
piman 2017/03/30 23:44:41 nit: ditto re: std::unique_ptr
Zhenyao Mo 2017/03/31 19:14:14 Done.
24 static GpuDriverBugList* Create(const GpuControlListData& data);
24 25
25 // Append |workarounds| with these passed in through the 26 // Append |workarounds| with these passed in through the
26 // |command_line|. 27 // |command_line|.
27 static void AppendWorkaroundsFromCommandLine( 28 static void AppendWorkaroundsFromCommandLine(
28 std::set<int>* workarounds, 29 std::set<int>* workarounds,
29 const base::CommandLine& command_line); 30 const base::CommandLine& command_line);
30 31
31 // Append |workarounds| with the full list of workarounds. 32 // Append |workarounds| with the full list of workarounds.
32 // This is needed for correctly passing flags down from 33 // This is needed for correctly passing flags down from
33 // the browser process to the GPU process. 34 // the browser process to the GPU process.
34 static void AppendAllWorkarounds(std::vector<const char*>* workarounds); 35 static void AppendAllWorkarounds(std::vector<const char*>* workarounds);
35 36
36 private: 37 private:
37 GpuDriverBugList(); 38 GpuDriverBugList(const GpuControlListData& data);
piman 2017/03/30 23:44:41 nit: explicit
Zhenyao Mo 2017/03/31 19:14:14 Done.
38 39
39 DISALLOW_COPY_AND_ASSIGN(GpuDriverBugList); 40 DISALLOW_COPY_AND_ASSIGN(GpuDriverBugList);
40 }; 41 };
41 42
42 } // namespace gpu 43 } // namespace gpu
43 44
44 #endif // GPU_CONFIG_GPU_DRIVER_BUG_LIST_H_ 45 #endif // GPU_CONFIG_GPU_DRIVER_BUG_LIST_H_
45 46
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698