Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Side by Side Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 2756733004: Disable flaky DevToolsBeforeUnloadTest.TestUndockedDevTools* tests (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/cancelable_callback.h" 10 #include "base/cancelable_callback.h"
(...skipping 693 matching lines...) Expand 10 before | Expand all | Expand 10 after
704 // Tests that BeforeUnload event gets called on docked devtools if 704 // Tests that BeforeUnload event gets called on docked devtools if
705 // we try to close them. 705 // we try to close them.
706 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest, TestDockedDevToolsClose) { 706 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest, TestDockedDevToolsClose) {
707 RunBeforeUnloadSanityTest(true, base::Bind( 707 RunBeforeUnloadSanityTest(true, base::Bind(
708 &DevToolsBeforeUnloadTest::CloseDevToolsWindowAsync, 708 &DevToolsBeforeUnloadTest::CloseDevToolsWindowAsync,
709 base::Unretained(this)), false); 709 base::Unretained(this)), false);
710 } 710 }
711 711
712 // Tests that BeforeUnload event gets called on docked devtools if 712 // Tests that BeforeUnload event gets called on docked devtools if
713 // we try to close the inspected page. 713 // we try to close the inspected page.
714 // Flaky on Windows, Linux and ChromiumOS. http://crbug.com/702171
715 #if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_CHROMEOS)
716 #define MAYBE_TestDockedDevToolsInspectedTabClose \
717 DISABLED_TestDockedDevToolsInspectedTabClose
718 #else
719 #define MAYBE_TestDockedDevToolsInspectedTabClose \
720 TestDockedDevToolsInspectedTabClose
721 #endif
714 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest, 722 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest,
715 TestDockedDevToolsInspectedTabClose) { 723 MAYBE_TestDockedDevToolsInspectedTabClose) {
716 RunBeforeUnloadSanityTest(true, base::Bind( 724 RunBeforeUnloadSanityTest(true, base::Bind(
717 &DevToolsBeforeUnloadTest::CloseInspectedTab, 725 &DevToolsBeforeUnloadTest::CloseInspectedTab,
718 base::Unretained(this))); 726 base::Unretained(this)));
719 } 727 }
720 728
721 // Tests that BeforeUnload event gets called on docked devtools if 729 // Tests that BeforeUnload event gets called on docked devtools if
722 // we try to close the inspected browser. 730 // we try to close the inspected browser.
723 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest, 731 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest,
724 TestDockedDevToolsInspectedBrowserClose) { 732 TestDockedDevToolsInspectedBrowserClose) {
725 RunBeforeUnloadSanityTest(true, base::Bind( 733 RunBeforeUnloadSanityTest(true, base::Bind(
726 &DevToolsBeforeUnloadTest::CloseInspectedBrowser, 734 &DevToolsBeforeUnloadTest::CloseInspectedBrowser,
727 base::Unretained(this))); 735 base::Unretained(this)));
728 } 736 }
729 737
730 // Tests that BeforeUnload event gets called on undocked devtools if 738 // Tests that BeforeUnload event gets called on undocked devtools if
731 // we try to close them. 739 // we try to close them.
732 // Flaky on Windows and Linux. http://crbug.com/702171 740 // Flaky on Windows, Linux and ChromiumOS. http://crbug.com/702171
733 #if defined(OS_WIN) || defined(OS_LINUX) 741 #if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_CHROMEOS)
734 #define MAYBE_TestUndockedDevToolsClose DISABLED_TestUndockedDevToolsClose 742 #define MAYBE_TestUndockedDevToolsClose DISABLED_TestUndockedDevToolsClose
735 #else 743 #else
736 #define MAYBE_TestUndockedDevToolsClose TestUndockedDevToolsClose 744 #define MAYBE_TestUndockedDevToolsClose TestUndockedDevToolsClose
737 #endif 745 #endif
738
739 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest, 746 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest,
740 MAYBE_TestUndockedDevToolsClose) { 747 MAYBE_TestUndockedDevToolsClose) {
741 RunBeforeUnloadSanityTest(false, base::Bind( 748 RunBeforeUnloadSanityTest(false, base::Bind(
742 &DevToolsBeforeUnloadTest::CloseDevToolsWindowAsync, 749 &DevToolsBeforeUnloadTest::CloseDevToolsWindowAsync,
743 base::Unretained(this)), false); 750 base::Unretained(this)), false);
744 } 751 }
745 752
746 // Tests that BeforeUnload event gets called on undocked devtools if 753 // Tests that BeforeUnload event gets called on undocked devtools if
747 // we try to close the inspected page. 754 // we try to close the inspected page.
748 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest, 755 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest,
749 TestUndockedDevToolsInspectedTabClose) { 756 TestUndockedDevToolsInspectedTabClose) {
750 RunBeforeUnloadSanityTest(false, base::Bind( 757 RunBeforeUnloadSanityTest(false, base::Bind(
751 &DevToolsBeforeUnloadTest::CloseInspectedTab, 758 &DevToolsBeforeUnloadTest::CloseInspectedTab,
752 base::Unretained(this))); 759 base::Unretained(this)));
753 } 760 }
754 761
755 // Tests that BeforeUnload event gets called on undocked devtools if 762 // Tests that BeforeUnload event gets called on undocked devtools if
756 // we try to close the inspected browser. 763 // we try to close the inspected browser.
764 // Flaky on Windows, Linux and ChromiumOS. http://crbug.com/702171
765 #if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_CHROMEOS)
766 #define MAYBE_TestUndockedDevToolsInspectedBrowserClose \
767 DISABLED_TestUndockedDevToolsInspectedBrowserClose
768 #else
769 #define MAYBE_TestUndockedDevToolsInspectedBrowserClose \
770 TestUndockedDevToolsInspectedBrowserClose
771 #endif
757 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest, 772 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest,
758 TestUndockedDevToolsInspectedBrowserClose) { 773 MAYBE_TestUndockedDevToolsInspectedBrowserClose) {
759 RunBeforeUnloadSanityTest(false, base::Bind( 774 RunBeforeUnloadSanityTest(false, base::Bind(
760 &DevToolsBeforeUnloadTest::CloseInspectedBrowser, 775 &DevToolsBeforeUnloadTest::CloseInspectedBrowser,
761 base::Unretained(this))); 776 base::Unretained(this)));
762 } 777 }
763 778
764 // Tests that BeforeUnload event gets called on undocked devtools if 779 // Tests that BeforeUnload event gets called on undocked devtools if
765 // we try to exit application. 780 // we try to exit application.
781 // Flaky on Windows, Linux and ChromiumOS. http://crbug.com/702171
782 #if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_CHROMEOS)
783 #define MAYBE_TestUndockedDevToolsApplicationClose \
784 DISABLED_TestUndockedDevToolsApplicationClose
785 #else
786 #define MAYBE_TestUndockedDevToolsApplicationClose \
787 TestUndockedDevToolsApplicationClose
788 #endif
766 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest, 789 IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest,
767 TestUndockedDevToolsApplicationClose) { 790 MAYBE_TestUndockedDevToolsApplicationClose) {
768 RunBeforeUnloadSanityTest(false, base::Bind( 791 RunBeforeUnloadSanityTest(false, base::Bind(
769 &chrome::CloseAllBrowsers)); 792 &chrome::CloseAllBrowsers));
770 } 793 }
771 794
772 // Tests that inspected tab gets closed if devtools renderer 795 // Tests that inspected tab gets closed if devtools renderer
773 // becomes unresponsive during beforeunload event interception. 796 // becomes unresponsive during beforeunload event interception.
774 // @see http://crbug.com/322380 797 // @see http://crbug.com/322380
775 // Disabled because of http://crbug.com/410327 798 // Disabled because of http://crbug.com/410327
776 IN_PROC_BROWSER_TEST_F(DevToolsUnresponsiveBeforeUnloadTest, 799 IN_PROC_BROWSER_TEST_F(DevToolsUnresponsiveBeforeUnloadTest,
777 DISABLED_TestUndockedDevToolsUnresponsive) { 800 DISABLED_TestUndockedDevToolsUnresponsive) {
(...skipping 771 matching lines...) Expand 10 before | Expand all | Expand 10 after
1549 RunTestFunction(window, "testWindowInitializedOnNavigateBack"); 1572 RunTestFunction(window, "testWindowInitializedOnNavigateBack");
1550 1573
1551 DevToolsWindowTesting::CloseDevToolsWindowSync(window); 1574 DevToolsWindowTesting::CloseDevToolsWindowSync(window);
1552 content::WebUIControllerFactory::UnregisterFactoryForTesting(&test_factory); 1575 content::WebUIControllerFactory::UnregisterFactoryForTesting(&test_factory);
1553 } 1576 }
1554 1577
1555 // Tests scripts panel showing. 1578 // Tests scripts panel showing.
1556 IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, TestDevToolsSharedWorker) { 1579 IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, TestDevToolsSharedWorker) {
1557 RunTest("testDevToolsSharedWorker", url::kAboutBlankURL); 1580 RunTest("testDevToolsSharedWorker", url::kAboutBlankURL);
1558 } 1581 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698