Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: media/filters/audio_renderer_impl.cc

Issue 275673002: Remove completion callbacks from AudioRenderer::Play/Pause(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/audio_renderer_impl.h ('k') | media/filters/audio_renderer_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/audio_renderer_impl.cc
diff --git a/media/filters/audio_renderer_impl.cc b/media/filters/audio_renderer_impl.cc
index faec58ef65f100dc80eaf625f85b54f7beb515de..e189c6134ceabe703aa4617bfbacdbdfb01fe4c7 100644
--- a/media/filters/audio_renderer_impl.cc
+++ b/media/filters/audio_renderer_impl.cc
@@ -73,13 +73,12 @@ AudioRendererImpl::~AudioRendererImpl() {
DCHECK(!algorithm_.get());
}
-void AudioRendererImpl::Play(const base::Closure& callback) {
+void AudioRendererImpl::Play() {
DCHECK(task_runner_->BelongsToCurrentThread());
base::AutoLock auto_lock(lock_);
DCHECK_EQ(state_, kPaused);
ChangeState_Locked(kPlaying);
- callback.Run();
earliest_end_time_ = now_cb_.Run();
if (algorithm_->playback_rate() != 0)
@@ -104,7 +103,7 @@ void AudioRendererImpl::DoPlay_Locked() {
}
}
-void AudioRendererImpl::Pause(const base::Closure& callback) {
+void AudioRendererImpl::Pause() {
DCHECK(task_runner_->BelongsToCurrentThread());
base::AutoLock auto_lock(lock_);
@@ -113,8 +112,6 @@ void AudioRendererImpl::Pause(const base::Closure& callback) {
ChangeState_Locked(kPaused);
DoPause_Locked();
-
- callback.Run();
}
void AudioRendererImpl::DoPause_Locked() {
« no previous file with comments | « media/filters/audio_renderer_impl.h ('k') | media/filters/audio_renderer_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698