Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Unified Diff: media/base/audio_renderer.h

Issue 275673002: Remove completion callbacks from AudioRenderer::Play/Pause(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/mock_filters.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/audio_renderer.h
diff --git a/media/base/audio_renderer.h b/media/base/audio_renderer.h
index 289685758873bfbaccdd9aece6ba508004d4da16..36890f6b23c9208e2533d483822bf881053fbdd9 100644
--- a/media/base/audio_renderer.h
+++ b/media/base/audio_renderer.h
@@ -47,13 +47,13 @@ class MEDIA_EXPORT AudioRenderer {
const base::Closure& ended_cb,
const PipelineStatusCB& error_cb) = 0;
- // Start audio decoding and rendering at the current playback rate, executing
- // |callback| when playback is underway.
- virtual void Play(const base::Closure& callback) = 0;
+ // Signal audio playback to start at the current rate. It is expected that
+ // |time_cb| will eventually start being run with time updates.
+ virtual void Play() = 0;
- // Temporarily suspend decoding and rendering audio, executing |callback| when
- // playback has been suspended.
- virtual void Pause(const base::Closure& callback) = 0;
+ // Signal audio playback to stop until further notice. It is expected that
+ // |time_cb| will no longer be run.
+ virtual void Pause() = 0;
// Discard any audio data, executing |callback| when completed.
virtual void Flush(const base::Closure& callback) = 0;
« no previous file with comments | « no previous file | media/base/mock_filters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698