Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: third_party/WebKit/Source/web/CompositorWorkerProxyClientImpl.cpp

Issue 2756703002: Don't expose a LayerImpl reference to CompositorProxy. (Closed)
Patch Set: Address smcgruer comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/CompositorMutatorImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/CompositorWorkerProxyClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/CompositorWorkerProxyClientImpl.cpp b/third_party/WebKit/Source/web/CompositorWorkerProxyClientImpl.cpp
index c564b861cb89f47fc1470e1b1f228a0ccf242fb3..cbc4bc5ff5561f2abd06b497235734a596708bce 100644
--- a/third_party/WebKit/Source/web/CompositorWorkerProxyClientImpl.cpp
+++ b/third_party/WebKit/Source/web/CompositorWorkerProxyClientImpl.cpp
@@ -27,7 +27,7 @@ class ScopedCompositorMutableState final {
: m_proxies(proxies) {
for (CompositorProxy* proxy : m_proxies) {
proxy->takeCompositorMutableState(
- stateProvider->getMutableStateFor(proxy->elementId()));
+ stateProvider->getMutableStateFor(proxy->proxyId()));
}
}
~ScopedCompositorMutableState() {
@@ -112,11 +112,17 @@ bool CompositorWorkerProxyClientImpl::executeAnimationFrameCallbacks(
void CompositorWorkerProxyClientImpl::registerCompositorProxy(
CompositorProxy* proxy) {
+ TRACE_EVENT0("compositor-worker",
+ "CompositorWorkerProxyClientImpl::registerCompositorProxy");
+ m_mutator->registerCompositorProxy(proxy);
m_proxies.insert(proxy);
}
void CompositorWorkerProxyClientImpl::unregisterCompositorProxy(
CompositorProxy* proxy) {
+ TRACE_EVENT0("compositor-worker",
+ "CompositorWorkerProxyClientImpl::unregisterCompositorProxy");
+ m_mutator->registerCompositorProxy(proxy);
m_proxies.erase(proxy);
}
« no previous file with comments | « third_party/WebKit/Source/web/CompositorMutatorImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698