third_party/WebKit/Source/core/dom/CompositorProxy.cpp - Issue 2756703002: Don't expose a LayerImpl reference to CompositorProxy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/CompositorProxy.cpp

Issue 2756703002: Don't expose a LayerImpl reference to CompositorProxy. (Closed)

Patch Set: Address smcgruer comments. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/CompositorProxy.cpp

diff --git a/third_party/WebKit/Source/core/dom/CompositorProxy.cpp b/third_party/WebKit/Source/core/dom/CompositorProxy.cpp

index e715638b804f420fddba14fb52c421ec4cc444a1..dd64f2ad144e38f14fc9fd347ad24310de02faa9 100644

--- a/third_party/WebKit/Source/core/dom/CompositorProxy.cpp

+++ b/third_party/WebKit/Source/core/dom/CompositorProxy.cpp

@@ -19,6 +19,9 @@

#include <algorithm>

namespace blink {

+namespace {

+uint64_t uniqueId = 0;

+} // namespace

static const struct {

const char* name;

@@ -135,6 +138,7 @@ CompositorProxy* CompositorProxy::create(ExecutionContext* context,

CompositorProxy::CompositorProxy(uint64_t elementId,

uint32_t compositorMutableProperties)

: m_elementId(elementId),

+ m_proxyId(uniqueId++),

m_compositorMutableProperties(compositorMutableProperties),

m_client(nullptr) {

DCHECK(m_compositorMutableProperties);