Add generic-methods 'golden' tests for 'reify' transformation

Srong-mode tests for generic methods
(`tests/language_strong/generic_methods_*`) are reused as 'golden' tests
for 'reify' transformation.

R=asgerf@google.com

Committed: https://github.com/dart-lang/sdk/commit/1ec9c979240cbfc6109cd7739b22213047def67e

[Dmitry Stefantsov, 2017-03-16 15:26:23]

Description was changed from

==========
Exclude tests that crash, create '.expect' files for the rest


Fix library names in generic methods test files


Rename generated tests and correct descriptions there


Remove multi-tests comments from generated test files


Change 'package:expect/expect.dart' to 'test_base.dart'


Reformat generated tests: remove unnecessary variables, apply dartfmt


Merge branch 'master' into generic-methods-02-test


Add non-multi-tests for generic methods to 'golden' tests of 'reify'


Delete tests with compile-time errors and "none" tests


Add generated tests for generic methods to golden 'reify' tests


Merge branch 'master' into generic-methods


Merge branch 'master' into generic-methods


Fix return types of generic methods in Closure Conversion

Use the substitution map with accumulated information about type
parameters instead of the empty map. The bug was only visible when a
generic method is a member of a non-generic class and has a return type
represented by a type parameter.

Update .expect files for golden tests in 'reify' package


Merge branch 'master' into generic-methods


Update golden test cases for 'reify' package


Change rules for detecting generic method

A generic method is:

* a constructor that has more type arguments than it's class
* a factory that has more type arguments than it's class
* any other (non-constructor and non-factory method) that has type
arguments

Only add type parameter argument to generic methods

Previously non-generics methods were given type parameters as well, and
they were passed a zero-length lists in invocations.

Do minor fixes suggested by karlklose@


Remove commented out attempt to remove type parameters


Adjust test suite for reify so that it runs in strong mode


Add simple test case for generic methods


Pass type arguments after children of invocation are transformed

This way the newly-added argument of the information itself isn't
transformed.

Pass type arguments in a list to generic methods

All generic methods are equipped with one extra named parameter for
passing type arguments as a list of type values.

Use strong mode for 'dartk' inside 'reified_dart'

Strong mode is required for loader to not strip away type arguments from
generic methods. We may opt for another command line argument for that
(e.g. --generic-methods) later, if the changes will land before the
strong mode.

BUG=
==========

to

==========
Srong-mode tests for generic methods
(`tests/language_strong/generic_methods_*`) are reused as 'golden' tests
for 'reify' transformation.
==========

[Dmitry Stefantsov, 2017-03-16 16:14:11]

dmitryas@google.com changed reviewers:
+ asgerf@google.com, karlklose@google.com, kmillikin@google.com

[Dmitry Stefantsov, 2017-03-16 16:14:12]

Hi guys,

I want to ask your opinion on how I plan my workflow on Generic Methods.
Basically, I want to add all of the tests that I have now, and improve the
transformation gradually, so that all tests pass in the end, and the '.expect'
files looks exactly like we want them to be.

The reason why I'm asking you is that I'm going to add a bunch of tests, most of
which either crash or fail. However, we don't run them on the buildbots, so it
should be ok.

I took the tests written for generic methods in strong mode and put them into
'golden' test cases directory for 'reify' transformation. I reformatted the
tests generated from multi-test files and adjusted the descriptions. For those
tests that don't crash, I generated '.expect' files.

Some of the added tests Crash, and some of them Fail. Yet other tests Pass, but
have '.expect' files without generic-methods support. I split the added tests
into the following 5 sets, based on their outcomes.


**Set 1. COMPILER. 5 tests.**

These tests need compiler support. They all crash at the first step of the
testing chain with errors like "Cannot compute LIBRARY_ELEMENT". They have a
single reason for that -- the new typedef syntax (`typedef f = T
Function<T>(T);`).


**Set 2. PREVIOUS. 2 tests.**

These tests compile and can be processed by the transformations that precede the
'reify' transformation. However, they fail to pass the sanity check after that.


**Set 3. REIFY. 5 tests.**

The 'reify' transformation crashes on these tests.


**Set 4. DART1. 5 tests.**

These tests can be processed by the whole transformation pipeline, but fail when
run. This is due to Dart 1 semantics for generic methods. Type parameters are
simply substituted with 'dynamic' that makes assertions fail.


**Set 5. EXPECT. 6 tests.**

These tests pass, but the generated '.expect' files don't represent
generic-methods semantics currently.


Tests in sets 1-3 crash, and those in set 4 fail. Tests in set 5 pass, but
should be considered anyway, because their '.expect' files don't represent the
desired behavior.

Eventually, some tests may change the set that they belong to. I don't expect
tests in any of these sets to be easier to fix than tests from other sets. It's
just to have a structure to work on.

[asgerf, 2017-03-17 10:17:48]

lgtm

https://codereview.chromium.org/2756693002/diff/1/pkg/kernel/test/reify/testi...
File pkg/kernel/test/reify/testing.json (right):

https://codereview.chromium.org/2756693002/diff/1/pkg/kernel/test/reify/testi...
pkg/kernel/test/reify/testing.json:30:
"/testcases/reify/generic_methods_unused_parameter_test\\.dart$"
I think these should be moved to the status file 'reify.status'.

[Dmitry Stefantsov, 2017-03-17 11:50:29]

https://codereview.chromium.org/2756693002/diff/1/pkg/kernel/test/reify/testi...
File pkg/kernel/test/reify/testing.json (right):

https://codereview.chromium.org/2756693002/diff/1/pkg/kernel/test/reify/testi...
pkg/kernel/test/reify/testing.json:30:
"/testcases/reify/generic_methods_unused_parameter_test\\.dart$"
On 2017/03/17 10:17:48, asgerf wrote:
> I think these should be moved to the status file 'reify.status'.

Good idea. Thanks! Done.

[Dmitry Stefantsov, 2017-03-17 11:51:42]

Description was changed from

==========
Srong-mode tests for generic methods
(`tests/language_strong/generic_methods_*`) are reused as 'golden' tests
for 'reify' transformation.
==========

to

==========
Srong-mode tests for generic methods
(`tests/language_strong/generic_methods_*`) are reused as 'golden' tests
for 'reify' transformation.

R=asgerf@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1ec9c979240cbfc6109cd7739b22213047def67e
==========

[Dmitry Stefantsov, 2017-03-17 11:51:43]

Committed patchset #2 (id:20001) manually as
1ec9c979240cbfc6109cd7739b22213047def67e (presubmit successful).