Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1479)

Unified Diff: content/shell/browser/layout_test/blink_test_controller.h

Issue 2756623002: DevTools: extract bindings from ShellDevToolsFrontend (Closed)
Patch Set: fixup Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/layout_test/blink_test_controller.h
diff --git a/content/shell/browser/layout_test/blink_test_controller.h b/content/shell/browser/layout_test/blink_test_controller.h
index 39ff4fd6c89d98ae68aee529ebdc3175d298c7ae..0d0759084ebbfbbd5e6dad0ed7ccfb4dbbe605a2 100644
--- a/content/shell/browser/layout_test/blink_test_controller.h
+++ b/content/shell/browser/layout_test/blink_test_controller.h
@@ -39,7 +39,7 @@ class SkBitmap;
namespace content {
class LayoutTestBluetoothChooserFactory;
-class LayoutTestDevToolsFrontend;
+class LayoutTestDevToolsBindings;
class RenderFrameHost;
class RenderProcessHost;
class Shell;
@@ -232,6 +232,10 @@ class BlinkTestController : public base::NonThreadSafe,
base::FilePath temp_path_;
Shell* main_window_;
+ std::unique_ptr<Shell> secondary_window_;
dgozman 2017/03/17 22:44:14 Let's call this devtools_window_ and remove one be
chenwilliam 2017/03/20 21:32:20 Done.
+
+ Shell* devtools_window_;
+ std::unique_ptr<LayoutTestDevToolsBindings> devtools_bindings_;
// The PID of the render process of the render view host of main_window_.
int current_pid_;
@@ -268,8 +272,6 @@ class BlinkTestController : public base::NonThreadSafe,
const bool is_leak_detection_enabled_;
bool crash_when_leak_found_;
- LayoutTestDevToolsFrontend* devtools_frontend_;
-
std::unique_ptr<LayoutTestBluetoothChooserFactory> bluetooth_chooser_factory_;
// Map from frame_tree_node_id into frame-specific dumps.

Powered by Google App Engine
This is Rietveld 408576698