Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: content/shell/browser/shell_devtools_bindings.h

Issue 2756623002: DevTools: extract bindings from ShellDevToolsFrontend (Closed)
Patch Set: fixup Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_SHELL_BROWSER_SHELL_DEVTOOLS_FRONTEND_H_ 5 #ifndef CONTENT_SHELL_BROWSER_SHELL_DEVTOOLS_BINDINGS_H_
6 #define CONTENT_SHELL_BROWSER_SHELL_DEVTOOLS_FRONTEND_H_ 6 #define CONTENT_SHELL_BROWSER_SHELL_DEVTOOLS_BINDINGS_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "base/memory/ref_counted.h" 12 #include "base/memory/ref_counted.h"
13 #include "base/memory/weak_ptr.h" 13 #include "base/memory/weak_ptr.h"
14 #include "base/values.h" 14 #include "base/values.h"
15 #include "content/public/browser/devtools_agent_host.h" 15 #include "content/public/browser/devtools_agent_host.h"
16 #include "content/public/browser/devtools_frontend_host.h" 16 #include "content/public/browser/devtools_frontend_host.h"
17 #include "content/public/browser/web_contents_observer.h" 17 #include "content/public/browser/web_contents_observer.h"
18 #include "net/url_request/url_fetcher_delegate.h" 18 #include "net/url_request/url_fetcher_delegate.h"
19 19
20 namespace base { 20 namespace base {
21 class Value; 21 class Value;
22 } 22 }
23 23
24 namespace content { 24 namespace content {
25 25
26 class RenderViewHost; 26 class ShellDevToolsDelegate {
27 class Shell; 27 public:
28 virtual void Close() = 0;
29 virtual ~ShellDevToolsDelegate(){};
30 };
31
28 class WebContents; 32 class WebContents;
29 33
30 class ShellDevToolsFrontend : public WebContentsObserver, 34 class ShellDevToolsBindings : public WebContentsObserver,
31 public DevToolsAgentHostClient, 35 public DevToolsAgentHostClient,
32 public net::URLFetcherDelegate { 36 public net::URLFetcherDelegate {
33 public: 37 public:
34 static ShellDevToolsFrontend* Show(WebContents* inspected_contents); 38 ShellDevToolsBindings(WebContents* devtools_contents,
39 WebContents* inspected_contents,
40 ShellDevToolsDelegate* delegate,
41 const std::string& settings,
42 const GURL& frontend_url);
35 43
36 void Activate();
37 void Focus();
38 void InspectElementAt(int x, int y); 44 void InspectElementAt(int x, int y);
39 void Close();
40
41 void DisconnectFromTarget();
42
43 Shell* frontend_shell() const { return frontend_shell_; }
44 45
45 void CallClientFunction(const std::string& function_name, 46 void CallClientFunction(const std::string& function_name,
46 const base::Value* arg1, 47 const base::Value* arg1,
47 const base::Value* arg2, 48 const base::Value* arg2,
48 const base::Value* arg3); 49 const base::Value* arg3);
50 ~ShellDevToolsBindings() override;
49 51
50 protected: 52 protected:
51 ShellDevToolsFrontend(Shell* frontend_shell, WebContents* inspected_contents);
52 ~ShellDevToolsFrontend() override;
53
54 // content::DevToolsAgentHostClient implementation. 53 // content::DevToolsAgentHostClient implementation.
55 void AgentHostClosed(DevToolsAgentHost* agent_host, bool replaced) override; 54 void AgentHostClosed(DevToolsAgentHost* agent_host, bool replaced) override;
56 void DispatchProtocolMessage(DevToolsAgentHost* agent_host, 55 void DispatchProtocolMessage(DevToolsAgentHost* agent_host,
57 const std::string& message) override; 56 const std::string& message) override;
57
58 void SetPreferences(const std::string& json); 58 void SetPreferences(const std::string& json);
59 virtual void HandleMessageFromDevToolsFrontend(const std::string& message); 59 virtual void HandleMessageFromDevToolsFrontend(const std::string& message);
60 60
61 private: 61 private:
62 // WebContentsObserver overrides 62 // WebContentsObserver overrides
63 void RenderViewCreated(RenderViewHost* render_view_host) override;
64 void DocumentAvailableInMainFrame() override; 63 void DocumentAvailableInMainFrame() override;
65 void WebContentsDestroyed() override; 64 void WebContentsDestroyed() override;
66 65
67 // net::URLFetcherDelegate overrides. 66 // net::URLFetcherDelegate overrides.
68 void OnURLFetchComplete(const net::URLFetcher* source) override; 67 void OnURLFetchComplete(const net::URLFetcher* source) override;
69 68
70 void SendMessageAck(int request_id, 69 void SendMessageAck(int request_id, const base::Value* arg1);
71 const base::Value* arg1);
72 70
73 Shell* frontend_shell_;
74 WebContents* inspected_contents_; 71 WebContents* inspected_contents_;
72 ShellDevToolsDelegate* delegate_;
75 scoped_refptr<DevToolsAgentHost> agent_host_; 73 scoped_refptr<DevToolsAgentHost> agent_host_;
76 int inspect_element_at_x_; 74 int inspect_element_at_x_;
77 int inspect_element_at_y_; 75 int inspect_element_at_y_;
78 std::unique_ptr<DevToolsFrontendHost> frontend_host_; 76 std::unique_ptr<DevToolsFrontendHost> frontend_host_;
79 using PendingRequestsMap = std::map<const net::URLFetcher*, int>; 77 using PendingRequestsMap = std::map<const net::URLFetcher*, int>;
80 PendingRequestsMap pending_requests_; 78 PendingRequestsMap pending_requests_;
81 base::DictionaryValue preferences_; 79 base::DictionaryValue preferences_;
82 base::WeakPtrFactory<ShellDevToolsFrontend> weak_factory_; 80 base::WeakPtrFactory<ShellDevToolsBindings> weak_factory_;
83 81
84 DISALLOW_COPY_AND_ASSIGN(ShellDevToolsFrontend); 82 DISALLOW_COPY_AND_ASSIGN(ShellDevToolsBindings);
85 }; 83 };
86 84
87 } // namespace content 85 } // namespace content
88 86
89 #endif // CONTENT_SHELL_BROWSER_SHELL_DEVTOOLS_FRONTEND_H_ 87 #endif // CONTENT_SHELL_BROWSER_SHELL_DEVTOOLS_BINDINGS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698