Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: ui/android/junit/src/org/chromium/ui/base/SelectFileDialogTest.java

Issue 2756593003: Fix UMA metric to not count multiple image/ tags as generic. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/android/junit/src/org/chromium/ui/base/SelectFileDialogTest.java
diff --git a/ui/android/junit/src/org/chromium/ui/base/SelectFileDialogTest.java b/ui/android/junit/src/org/chromium/ui/base/SelectFileDialogTest.java
index 9c195f11a9856e7ac69e0ff97f461caa60034e68..aaae9c83351e4f486498a9e400aef9b3ad28b84f 100644
--- a/ui/android/junit/src/org/chromium/ui/base/SelectFileDialogTest.java
+++ b/ui/android/junit/src/org/chromium/ui/base/SelectFileDialogTest.java
@@ -51,6 +51,10 @@ public class SelectFileDialogTest {
SelectFileDialog.SELECT_FILE_DIALOG_SCOPE_VIDEOS, scopeForFileTypes("video/ogg"));
assertEquals(SelectFileDialog.SELECT_FILE_DIALOG_SCOPE_GENERIC,
scopeForFileTypes("video/*", "test/plain"));
+ assertEquals(SelectFileDialog.SELECT_FILE_DIALOG_SCOPE_IMAGES,
+ scopeForFileTypes("image/x-png", "image/gif", "image/jpeg"));
+ assertEquals(SelectFileDialog.SELECT_FILE_DIALOG_SCOPE_GENERIC,
+ scopeForFileTypes("image/x-png", "image/gif", "image/jpeg", "text/plain"));
assertEquals(SelectFileDialog.SELECT_FILE_DIALOG_SCOPE_IMAGES_AND_VIDEOS,
scopeForFileTypes("video/*", "image/*"));
« no previous file with comments | « ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698