Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2756583002: [Devtools] Added ability to add extension columns to network (Closed)
Patch Set: changes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
index 829f21fc5fb022e851f68486f62c318dd04bd7f7..8b0d409cd6a07c9a9d66de1dc244998058278526 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
@@ -107,7 +107,8 @@ Network.NetworkLogView = class extends UI.VBox {
this._resetSuggestionBuilder();
this._initializeView();
- Common.moduleSetting('networkColorCodeResourceTypes').addChangeListener(this._invalidateAllItems, this);
+ Common.moduleSetting('networkColorCodeResourceTypes')
+ .addChangeListener(this._invalidateAllItems.bind(this, false), this);
SDK.targetManager.observeTargets(this);
SDK.targetManager.addModelListener(
@@ -532,6 +533,10 @@ Network.NetworkLogView = class extends UI.VBox {
return [this._dataGrid.scrollContainer];
}
+ columnExtensionResolved() {
+ this._invalidateAllItems(true);
+ }
+
_setupDataGrid() {
/** @type {!DataGrid.SortableDataGrid<!Network.NetworkNode>} */
this._dataGrid = this._columns.dataGrid();
@@ -683,11 +688,17 @@ Network.NetworkLogView = class extends UI.VBox {
this._refresh();
}
- _invalidateAllItems() {
+ /**
+ * @param {boolean=} deferUpdate
+ */
+ _invalidateAllItems(deferUpdate) {
var requestIds = this._nodesByRequestId.keysArray();
for (var i = 0; i < requestIds.length; ++i)
this._staleRequestIds[requestIds[i]] = true;
- this._refresh();
+ if (deferUpdate)
+ this.scheduleRefresh();
+ else
+ this._refresh();
}
/**
@@ -873,6 +884,7 @@ Network.NetworkLogView = class extends UI.VBox {
if (group)
return group;
group = new Network.NetworkGroupNode(this, groupName);
+ group.setColumnExtensions(this._columns.columnExtensions());
this._nodeGroups.set(groupName, group);
return group;
}
@@ -934,6 +946,7 @@ Network.NetworkLogView = class extends UI.VBox {
*/
_appendRequest(request) {
var node = new Network.NetworkRequestNode(this, request);
+ node.setColumnExtensions(this._columns.columnExtensions());
node[Network.NetworkLogView._isFilteredOutSymbol] = true;
node[Network.NetworkLogView._isMatchingSearchQuerySymbol] = false;

Powered by Google App Engine
This is Rietveld 408576698