[Devtools] Added ability to add extension columns to network

third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @unrestricted
  */
 Network.NetworkLogViewColumns = class {
   /**
    * @param {!Network.NetworkLogView} networkLogView
    * @param {!Network.NetworkTransferTimeCalculator} timeCalculator
@@ skipping 11 matching lines @@
 
     /** @type {!Map<string, !Array<number>>} */
     this._eventDividers = new Map();
     this._eventDividersShown = false;
 
     this._gridMode = true;
 
     /** @type {!Array.<!Network.NetworkLogViewColumns.Descriptor>} */
     this._columns = [];
 
+    /** @type {!Map<string, ?Network.NetworkColumnExtensionInterface>} */
+    this._columnExtensions = new Map();
+
     this._waterfallRequestsAreStale = false;
     this._waterfallScrollerWidthIsStale = true;
 
     /** @type {!Components.Linkifier} */
     this._popupLinkifier = new Components.Linkifier();
 
     /** @type {!Map<string, !Network.NetworkTimeCalculator>} */
     this._calculatorsMap = new Map();
     this._calculatorsMap.set(Network.NetworkLogViewColumns._calculatorTypes.Time, timeCalculator);
     this._calculatorsMap.set(Network.NetworkLogViewColumns._calculatorTypes.Duration, durationCalculator);
@@ skipping 37 matching lines @@
 
     this._columns = /** @type {!Array<!Network.NetworkLogViewColumns.Descriptor>} */ ([]);
     for (var currentConfigColumn of defaultColumns) {
       var columnConfig = /** @type {!Network.NetworkLogViewColumns.Descriptor} */ (
           Object.assign(/** @type {!Object} */ ({}), defaultColumnConfig, currentConfigColumn));
       columnConfig.id = columnConfig.id;
       if (columnConfig.subtitle)
         columnConfig.titleDOMFragment = this._makeHeaderFragment(columnConfig.title, columnConfig.subtitle);
       this._columns.push(columnConfig);
     }
+    this._loadColumnExtensions();
     this._loadCustomColumnsAndSettings();
 
     this._popoverHelper = new UI.PopoverHelper(this._networkLogView.element);
     this._popoverHelper.initializeCallbacks(
         this._getPopoverAnchor.bind(this), this._showPopover.bind(this), this._onHidePopover.bind(this));
     this._popoverHelper.setHasPadding(true);
 
     /** @type {!DataGrid.SortableDataGrid<!Network.NetworkNode>} */
     this._dataGrid =
         new DataGrid.SortableDataGrid(this._columns.map(Network.NetworkLogViewColumns._convertToDataGridDescriptor));
@@ skipping 221 matching lines @@
       this._networkLogView.removeAllNodeHighlights();
       this._splitWidget.hideSidebar();
       this._activeScroller = this._dataGridScroller;
       this._dataGrid.setScrollContainer(this._dataGridScroller);
     }
     this._networkLogView.element.classList.toggle('brief-mode', !gridMode);
     this._updateColumns();
   }
 
   /**
+   * @return {!Map<string, ?Network.NetworkColumnExtensionInterface>}
+   */
+  columnExtensions() {
+    return this._columnExtensions;
+  }
+
+  /**
    * @param {!Network.NetworkLogViewColumns.Descriptor} columnConfig
    */
   _toggleColumnVisibility(columnConfig) {
     this._loadCustomColumnsAndSettings();
     columnConfig.visible = !columnConfig.visible;
     this._saveColumnsSettings();
     this._updateColumns();
   }
 
   _saveColumnsSettings() {
     var saveableSettings = {};
     for (var columnConfig of this._columns)
       saveableSettings[columnConfig.id] = {visible: columnConfig.visible, title: columnConfig.title};
 
     this._persistantSettings.set(saveableSettings);
   }
 
+  _loadColumnExtensions() {
+    var extensions = self.runtime.extensions(Network.NetworkColumnExtensionInterface);
+    for (var i = 0; i < extensions.length; i++) {
+      var extension = extensions[i];
+      var title = extension.title();
+      var columnId = title.toLowerCase() + '-extension';
+
+      this._columnExtensions.set(columnId, null);
+      extension.instance().then(extensionInstanceResolved.bind(this, columnId));
+
+      var columnConfig = /** @type {!Network.NetworkLogViewColumns.Descriptor} */ (
+          Object.assign(/** @type {!Object} */ ({}), Network.NetworkLogViewColumns._defaultColumnConfig, {

[caseq, 2017/03/17 00:16:29]

I think this cast should not be required.

[allada, 2017/03/17 01:16:09]

Done.

+            id: columnId,
+            title: title,
+            isResponseHeader: false,
+            isCustomHeader: false,
+            visible: true,
+            sortingFunction:
+                Network.NetworkRequestNode.ExtensionColumnComparator.bind(null, this._columnExtensions, columnId)
+          }));
+      const columnIndex = i + 1;
+      this._columns.splice(columnIndex, 0, columnConfig);
+      if (this._dataGrid)
+        this._dataGrid.addColumn(Network.NetworkLogViewColumns._convertToDataGridDescriptor(columnConfig), columnIndex);
+    }
+
+    /**
+     * @param {string} columnId
+     * @param {!Network.NetworkColumnExtensionInterface} instance
+     * @this {Network.NetworkLogViewColumns}
+     */
+    function extensionInstanceResolved(columnId, instance) {
+      this._columnExtensions.set(columnId, instance);
+      this._networkLogView.columnExtensionResolved();
+    }
+  }
+
   _loadCustomColumnsAndSettings() {
     var savedSettings = this._persistantSettings.get();
     var columnIds = Object.keys(savedSettings);
     for (var columnId of columnIds) {
       var setting = savedSettings[columnId];
       var columnConfig = this._columns.find(columnConfig => columnConfig.id === columnId);
       if (!columnConfig)
         columnConfig = this._addCustomHeader(setting.title, columnId);
       if (columnConfig.hideable && typeof setting.visible === 'boolean')
         columnConfig.visible = !!setting.visible;
@@ skipping 450 matching lines @@
 /**
  * @enum {string}
  */
 Network.NetworkLogViewColumns.WaterfallSortIds = {
   StartTime: 'startTime',
   ResponseTime: 'responseReceivedTime',
   EndTime: 'endTime',
   Duration: 'duration',
   Latency: 'latency'
 };
+
+/**
+ * @interface
+ */
+Network.NetworkColumnExtensionInterface = function() {};
+
+Network.NetworkColumnExtensionInterface.prototype = {
+  /**
+   * @param {!SDK.NetworkRequest} request
+   * @return {string}
+   */
+  lookupColumnValue(request) {}
+};