[Devtools] Added ability to add extension columns to network

third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 20 matching lines @@
 /**
  * @unrestricted
  */
 Network.NetworkNode = class extends DataGrid.SortableDataGridNode {
   /**
    * @param {!Network.NetworkLogView} parentView
    */
   constructor(parentView) {
     super({});
     this._parentView = parentView;
+    /**
+     * @protected
+     * @type {!Map<string, ?Network.NetworkColumnExtensionInterface>}
+     */
+    this.columnExtensions = new Map();
     this._isHovered = false;
     this._showingInitiatorChain = false;
     /** @type {?SDK.NetworkRequest} */
     this._requestOrFirstKnownChildRequest = null;
   }
 
   /**
    * @return {!Network.NetworkLogView}
    */
   parentView() {
@@ skipping 16 matching lines @@
 
   /**
    * @override
    * @return {number}
    */
   nodeSelfHeight() {
     return this._parentView.rowHeight();
   }
 
   /**
+   * @param {!Map<string, ?Network.NetworkColumnExtensionInterface>} columnExtensions
+   */
+  setColumnExtensions(columnExtensions) {
+    this.columnExtensions = columnExtensions;
+  }
+
+  /**
    * @param {boolean} hovered
    * @param {boolean} showInitiatorChain
    */
   setHovered(hovered, showInitiatorChain) {
     if (this._isHovered === hovered && this._showingInitiatorChain === showInitiatorChain)
       return;
     if (this._isHovered !== hovered) {
       this._isHovered = hovered;
       if (this.attached())
         this.element().classList.toggle('hover', hovered);
@@ skipping 370 matching lines @@
     var aHeader = aRequest.responseHeaderValue(propertyName);
     var bHeader = bRequest.responseHeaderValue(propertyName);
     var aValue = aHeader ? new Date(aHeader).getTime() : -Infinity;
     var bValue = bHeader ? new Date(bHeader).getTime() : -Infinity;
     if (aValue === bValue)
       return aRequest.indentityCompare(bRequest);
     return aValue > bValue ? 1 : -1;
   }
 
   /**
+   * @param {!Map<string, ?Network.NetworkColumnExtensionInterface>} extensionsMap
+   * @param {string} extensionId
+   * @param {!Network.NetworkNode} a
+   * @param {!Network.NetworkNode} b
+   * @return {number}
+   */
+  static ExtensionColumnComparator(extensionsMap, extensionId, a, b) {
+    var aRequest = a.requestOrFirstKnownChildRequest();
+    var bRequest = b.requestOrFirstKnownChildRequest();
+    if (!aRequest || !bRequest)
+      return !aRequest ? -1 : 1;
+    var instance = extensionsMap.get(extensionId);
+    if (!instance)
+      return aRequest.indentityCompare(bRequest);
+    var aValue = instance.lookup(aRequest) || '';
+    var bValue = instance.lookup(bRequest) || '';
+    if (aValue === bValue)
+      return aRequest.indentityCompare(bRequest);
+    return aValue > bValue ? 1 : -1;
+  }
+
+  /**
    * @override
    */
   showingInitiatorChainChanged() {
     var showInitiatorChain = this.showingInitiatorChain();
 
     var initiatorGraph = SDK.NetworkLog.initiatorGraphForRequest(this._request);
     for (var request of initiatorGraph.initiators) {
       if (request === this._request)
         continue;
       var node = this.parentView().nodeForRequest(request);
@@ skipping 120 matching lines @@
     element.title = text;
   }
 
   /**
    * @override
    * @param {string} columnIdentifier
    * @return {!Element}
    */
   createCell(columnIdentifier) {
     var cell = this.createTD(columnIdentifier);
+    // If the key exists but the value is null it means the extension instance has not resolved yet.
+    // The view controller will force all rows to update when extension is resolved.
+    if (this.columnExtensions.has(columnIdentifier)) {
+      var instance = this.columnExtensions.get(columnIdentifier);
+      if (instance)
+        this._setTextAndTitle(cell, instance.lookup(this._request) || '');
+      return cell;
+    }
     switch (columnIdentifier) {
       case 'name':
         this._renderNameCell(cell);
         break;
       case 'method':
         this._setTextAndTitle(cell, this._request.requestMethod);
         break;
       case 'status':
         this._renderStatusCell(cell);
         break;
@@ skipping 330 matching lines @@
     element.title = text;
   }
 
   /**
    * @override
    * @param {string} columnIdentifier
    * @return {!Element}
    */
   createCell(columnIdentifier) {
     var cell = this.createTD(columnIdentifier);
+    if (this.columnExtensions.has(columnIdentifier))

[allada, 2017/03/15 21:42:02]

This is the createCell for group nodes which we currently never want to put
extension data into their cell since currently the only extension is for the
"product" which is the "name" of the cell. Otherwise it'd be verbose.

+      return cell;
     if (columnIdentifier === 'name') {
       var leftPadding = this.leftPadding ? this.leftPadding + 'px' : '';
       cell.style.setProperty('padding-left', leftPadding);
       cell.classList.add('disclosure');
       this._setTextAndTitle(cell, this._displayName);
     }
     return cell;
   }
 
   /**
    * @override
    * @param {boolean=} supressSelectedEvent
    */
   select(supressSelectedEvent) {
     if (this.expanded) {
       this.collapse();
       return;
     }
     this.expand();
   }
 };