Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElementPersistentVideoTest.cpp

Issue 2756553002: Force the video to go fullscreen when setting persistent video (Closed)
Patch Set: fixed build Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | third_party/WebKit/public/platform/WebMediaPlayerClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLMediaElementPersistentVideoTest.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElementPersistentVideoTest.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElementPersistentVideoTest.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..3b4adc43da3f235997943797309f7fa5f16955fc
--- /dev/null
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElementPersistentVideoTest.cpp
@@ -0,0 +1,161 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/html/HTMLMediaElement.h"
+
+#include <memory>
+
+#include "core/dom/DocumentUserGestureToken.h"
+#include "core/dom/Fullscreen.h"
+#include "core/html/HTMLDivElement.h"
+#include "core/loader/EmptyClients.h"
+#include "core/testing/DummyPageHolder.h"
+#include "platform/UserGestureIndicator.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace blink {
+
+namespace {
+
+class MockChromeClient : public EmptyChromeClient {
+ public:
+ MOCK_METHOD1(enterFullscreen, void(LocalFrame&));
+ MOCK_METHOD1(exitFullscreen, void(LocalFrame&));
+};
+
+using ::testing::_;
+using ::testing::Sequence;
+
+} // anonymous namespace
+
+class HTMLMediaElementPersistentVideoTest : public ::testing::Test {
+ protected:
+ void SetUp() override {
+ m_chromeClient = new MockChromeClient();
+
+ Page::PageClients clients;
+ fillWithEmptyClients(clients);
+ clients.chromeClient = m_chromeClient.get();
+
+ m_pageHolder = DummyPageHolder::create(IntSize(800, 600), &clients);
+ document().body()->setInnerHTML("<body><div><video></video></div></body>");
+ }
+
+ Document& document() { return m_pageHolder->document(); }
+
+ HTMLMediaElement* videoElement() {
+ return toHTMLMediaElement(document().querySelector("video"));
+ }
+
+ HTMLDivElement* divElement() {
+ return toHTMLDivElement(document().querySelector("div"));
+ }
+
+ Element* fullscreenElement() {
+ return Fullscreen::currentFullScreenElementFrom(document());
+ }
+
+ MockChromeClient& mockChromeClient() { return *m_chromeClient; }
+
+ void simulateDidEnterFullscreen() {
+ Fullscreen::fromIfExists(document())->didEnterFullscreen();
+ }
+
+ void simulateDidExitFullscreen() {
+ Fullscreen::fromIfExists(document())->didExitFullscreen();
+ }
+
+ void simulateBecamePersistentVideo(bool value) {
+ videoElement()->onBecamePersistentVideo(value);
+ }
+
+ bool isPersistentVideo() { return videoElement()->m_isPersistentVideo; }
+
+ private:
+ std::unique_ptr<DummyPageHolder> m_pageHolder;
+ Persistent<MockChromeClient> m_chromeClient;
+};
+
+TEST_F(HTMLMediaElementPersistentVideoTest, testWhenNothingIsFullscreen) {
+ Sequence s;
+
+ EXPECT_EQ(fullscreenElement(), nullptr);
+
+ EXPECT_CALL(mockChromeClient(), enterFullscreen(_)).InSequence(s);
+
+ // Make the video persistent.
+ simulateBecamePersistentVideo(true);
+ simulateDidEnterFullscreen();
+ EXPECT_EQ(fullscreenElement(), videoElement());
+ EXPECT_TRUE(isPersistentVideo());
+
+ // This should be no-op.
+ simulateBecamePersistentVideo(true);
mlamouri (slow - plz ping) 2017/03/16 17:44:49 Maybe add checks verifying that it's a no-op?
Zhiqiang Zhang (Slow) 2017/03/16 18:08:26 Done.
+
+ // Make the video not persitent.
+ EXPECT_CALL(mockChromeClient(), exitFullscreen(_)).InSequence(s);
+ simulateBecamePersistentVideo(false);
+ simulateDidExitFullscreen();
+ EXPECT_EQ(fullscreenElement(), nullptr);
+ EXPECT_FALSE(isPersistentVideo());
+
+ // This should be no-op.
+ simulateBecamePersistentVideo(false);
mlamouri (slow - plz ping) 2017/03/16 17:44:49 Maybe we should check that the video is not fullsc
Zhiqiang Zhang (Slow) 2017/03/16 18:08:26 Done.
+}
+
+TEST_F(HTMLMediaElementPersistentVideoTest, testWhenVideoIsFullscreen) {
+ EXPECT_EQ(fullscreenElement(), nullptr);
+
+ EXPECT_CALL(mockChromeClient(), enterFullscreen(_)).Times(1);
+ EXPECT_CALL(mockChromeClient(), exitFullscreen(_)).Times(0);
+
+ // Fullscreen the video in advance.
+ UserGestureIndicator gestureIndicator(
+ DocumentUserGestureToken::create(&document()));
+ Fullscreen::requestFullscreen(*videoElement());
+ simulateDidEnterFullscreen();
+ EXPECT_EQ(fullscreenElement(), videoElement());
+
+ // This should be no-op.
+ simulateBecamePersistentVideo(true);
+ EXPECT_EQ(fullscreenElement(), videoElement());
+ EXPECT_FALSE(isPersistentVideo());
+
+ // This should be no-op.
+ simulateBecamePersistentVideo(false);
+ EXPECT_EQ(fullscreenElement(), videoElement());
+ EXPECT_FALSE(isPersistentVideo());
+}
+
+TEST_F(HTMLMediaElementPersistentVideoTest, testWhenDivIsFullscreen) {
+ EXPECT_EQ(fullscreenElement(), nullptr);
+
+ EXPECT_CALL(mockChromeClient(), enterFullscreen(_)).Times(2);
+ EXPECT_CALL(mockChromeClient(), exitFullscreen(_)).Times(0);
+
+ // Fullscreen the video in advance.
+ UserGestureIndicator gestureIndicator(
+ DocumentUserGestureToken::create(&document()));
+ Fullscreen::requestFullscreen(*divElement());
+ simulateDidEnterFullscreen();
+ EXPECT_EQ(fullscreenElement(), divElement());
+
+ // Make the video persistent.
+ simulateBecamePersistentVideo(true);
+ simulateDidEnterFullscreen();
+ EXPECT_EQ(fullscreenElement(), videoElement());
+ EXPECT_TRUE(isPersistentVideo());
+
+ // This should be no-op.
+ simulateBecamePersistentVideo(true);
mlamouri (slow - plz ping) 2017/03/16 17:44:49 same as above.
Zhiqiang Zhang (Slow) 2017/03/16 18:08:26 Done.
+
+ // Make the video not persistent. Don't call simulateDidExitFullscreen as
+ // there still a fullscreen element in stack.
+ simulateBecamePersistentVideo(false);
+ EXPECT_EQ(fullscreenElement(), divElement());
+ EXPECT_FALSE(isPersistentVideo());
+}
+
+} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | third_party/WebKit/public/platform/WebMediaPlayerClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698