Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4802)

Unified Diff: content/browser/media/media_web_contents_observer.h

Issue 2756553002: Force the video to go fullscreen when setting persistent video (Closed)
Patch Set: addressed nits Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/media/media_web_contents_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/media_web_contents_observer.h
diff --git a/content/browser/media/media_web_contents_observer.h b/content/browser/media/media_web_contents_observer.h
index a4ce3a657cb9aed4f2e26f4686f3ae28def2c600..3a2a0d3a5c3c8b8b8dc2c0d3de3c532eb58a4c05 100644
--- a/content/browser/media/media_web_contents_observer.h
+++ b/content/browser/media/media_web_contents_observer.h
@@ -57,6 +57,12 @@ class CONTENT_EXPORT MediaWebContentsObserver : public WebContentsObserver {
void WasShown() override;
void WasHidden() override;
+ // TODO(zqzhang): this method is temporarily in MediaWebContentsObserver as
+ // the effectively fullscreen video code is also here. We need to consider
+ // merging the logic of effectively fullscreen, hiding media controls and
+ // fullscreening video element to the same place.
+ void RequestPersistentVideo(bool value);
+
bool has_audio_power_save_blocker_for_testing() const {
return !!audio_power_save_blocker_;
}
« no previous file with comments | « no previous file | content/browser/media/media_web_contents_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698