Issue 2756543003: Lower shift-left when count is masked into valid range.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2756543003: Lower shift-left when count is masked into valid range. (Closed)

Created:
3 years, 9 months ago by sra1

Modified:
3 years, 9 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Lower shift-left when count is masked into valid range. This pattern, e.g. (1 << (a & 15)), occurs in Uri parsing. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/4a8ed3c260dc9e4c35703d21e2e66d4b99f5f5f0

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -5 lines)			Patch
	M	pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart	View		1 chunk	+17 lines, -5 lines	0 comments	Download

Total messages: 5 (2 generated)

sra1

3 years, 9 months ago (2017-03-16 01:52:39 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4a8ed3c260dc9e4c35703d21e2e66d4b99f5f5f0 (presubmit successful).