Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: ios/chrome/browser/web/navigation_manager_util_unittest.mm

Issue 2756483006: Adds NavigationManager util functions to ios/chrome/browser/web/ (Closed)
Patch Set: added dependencies to BUILD.gn Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/web/navigation_manager_util_unittest.mm
diff --git a/ios/chrome/browser/web/navigation_manager_util_unittest.mm b/ios/chrome/browser/web/navigation_manager_util_unittest.mm
new file mode 100644
index 0000000000000000000000000000000000000000..7e3e937ed021db1b5ab5d5655f0c2347aaa6fb95
--- /dev/null
+++ b/ios/chrome/browser/web/navigation_manager_util_unittest.mm
@@ -0,0 +1,83 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ios/chrome/browser/web/navigation_manager_util.h"
Eugene But (OOO till 7-30) 2017/03/17 14:32:04 s/include/import
pkl (ping after 24h if needed) 2017/03/17 20:23:53 Done.
+
+#import "ios/web/public/navigation_item.h"
+#import "ios/web/public/test/fakes/test_navigation_manager.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#import "testing/gtest_mac.h"
+#include "testing/platform_test.h"
+#include "ui/base/page_transition_types.h"
+#include "url/gurl.h"
+
+class NavigationManagerUtilTest : public PlatformTest {
+ protected:
+ web::TestNavigationManager nav_manager_;
+};
+
+// Tests that empty navigation manager returns nullptr.
+TEST_F(NavigationManagerUtilTest, TestLastNonRedirectedItemEmpty) {
+ EXPECT_FALSE(GetLastNonRedirectedItem(&nav_manager_));
+}
+
+// Tests that typed in URL works correctly.
+TEST_F(NavigationManagerUtilTest, TestLastNonRedirectedItemTypedUrl) {
+ nav_manager_.AddItem(GURL("http://foo.com/page0"), ui::PAGE_TRANSITION_TYPED);
+ web::NavigationItem* item = GetLastNonRedirectedItem(&nav_manager_);
+ ASSERT_TRUE(item);
+ EXPECT_TRUE(ui::PageTransitionTypeIncludingQualifiersIs(
+ item->GetTransitionType(), ui::PAGE_TRANSITION_TYPED));
+}
+
+// Tests that link click works correctly.
+TEST_F(NavigationManagerUtilTest, TestLastNonRedirectedItemLinkClicked) {
+ nav_manager_.AddItem(GURL("http://foo.com/page0"), ui::PAGE_TRANSITION_LINK);
+ web::NavigationItem* item = GetLastNonRedirectedItem(&nav_manager_);
+ ASSERT_TRUE(item);
+ EXPECT_TRUE(ui::PageTransitionTypeIncludingQualifiersIs(
+ item->GetTransitionType(), ui::PAGE_TRANSITION_LINK));
+}
+
+// Tests that redirect items are skipped.
+TEST_F(NavigationManagerUtilTest, TestLastNonRedirectedItemLinkMultiRedirects) {
+ nav_manager_.AddItem(GURL("http://foo.com/page0"), ui::PAGE_TRANSITION_LINK);
+ nav_manager_.AddItem(GURL("http://bar.com/redir1"),
+ ui::PAGE_TRANSITION_CLIENT_REDIRECT);
+ nav_manager_.AddItem(GURL("http://bar.com/redir2"),
+ ui::PAGE_TRANSITION_CLIENT_REDIRECT);
+ web::NavigationItem* item = GetLastNonRedirectedItem(&nav_manager_);
+ ASSERT_TRUE(item);
+ EXPECT_TRUE(ui::PageTransitionTypeIncludingQualifiersIs(
+ item->GetTransitionType(), ui::PAGE_TRANSITION_LINK));
+}
+
+// Tests that when all items are redirects, the first one is returned.
+TEST_F(NavigationManagerUtilTest, TestLastNonRedirectedItemAllRedirects) {
+ nav_manager_.AddItem(GURL("http://bar.com/redir0"),
+ ui::PAGE_TRANSITION_SERVER_REDIRECT);
+ nav_manager_.AddItem(GURL("http://bar.com/redir1"),
+ ui::PAGE_TRANSITION_CLIENT_REDIRECT);
+ nav_manager_.AddItem(GURL("http://bar.com/redir2"),
+ ui::PAGE_TRANSITION_CLIENT_REDIRECT);
+ web::NavigationItem* item = GetLastNonRedirectedItem(&nav_manager_);
+ ASSERT_TRUE(item);
+ EXPECT_TRUE(ui::PageTransitionTypeIncludingQualifiersIs(
+ item->GetTransitionType(), ui::PAGE_TRANSITION_SERVER_REDIRECT));
+}
+
+// Tests that earlier redirects are not found.
+TEST_F(NavigationManagerUtilTest, TestLastNonRedirectedItemNotEarliest) {
+ nav_manager_.AddItem(GURL("http://foo.com/bookmark"),
+ ui::PAGE_TRANSITION_AUTO_BOOKMARK);
+ nav_manager_.AddItem(GURL("http://foo.com/page0"), ui::PAGE_TRANSITION_TYPED);
+ nav_manager_.AddItem(GURL("http://bar.com/redir1"),
+ ui::PAGE_TRANSITION_CLIENT_REDIRECT);
+ nav_manager_.AddItem(GURL("http://bar.com/redir2"),
+ ui::PAGE_TRANSITION_CLIENT_REDIRECT);
+ web::NavigationItem* item = GetLastNonRedirectedItem(&nav_manager_);
+ ASSERT_TRUE(item);
+ EXPECT_TRUE(ui::PageTransitionTypeIncludingQualifiersIs(
+ item->GetTransitionType(), ui::PAGE_TRANSITION_TYPED));
+}

Powered by Google App Engine
This is Rietveld 408576698