ios/chrome/browser/web/navigation_manager_util.h - Issue 2756483006: Adds NavigationManager util functions to ios/chrome/browser/web/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/web/navigation_manager_util.h

Issue 2756483006: Adds NavigationManager util functions to ios/chrome/browser/web/ (Closed)

Patch Set: added dependencies to BUILD.gn Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CHROME_BROWSER_WEB_NAVIGATION_MANAGER_UTIL_H_

	6 #define IOS_CHROME_BROWSER_WEB_NAVIGATION_MANAGER_UTIL_H_

	7

	8 #import "ios/web/public/navigation_item.h"

	9 #import "ios/web/public/navigation_manager.h"

	10

	11 // Utility functions built on web::NavigationManager public API.

	12

	13 // Returns the most recent navigation item that is not the result of an HTTP

	14 // Redirect. Returns nullptr if \|nav_manager\| is empty or the first item if
	Eugene But (OOO till 7-30) 2017/03/17 14:32:04 It's quite unexpected that GetLastNonRedirectedIte It's quite unexpected that GetLastNonRedirectedItem can actually return a redirect item. Is there a reason for that? kkhorimoto 2017/03/17 17:16:58 The only use case of \|-lastUserItem\| was for reloa Show quoted text On 2017/03/17 14:32:04, Eugene But wrote: > It's quite unexpected that GetLastNonRedirectedItem can actually return a > redirect item. Is there a reason for that? The only use case of \|-lastUserItem\| was for reloading a page using a new user agent, so if we traverse the whole history and the last one is a REDIRECT type, we still return it because that's the best idea we have for the URL to attempt to reload. You're right that this is unexpected behavior given the new naming. Maybe we should just return nullptr in that case, then handle a null return value when we're actually doing the reload. pkl (ping after 24h if needed) 2017/03/17 20:23:52 Acknowledged. Show quoted text On 2017/03/17 14:32:04, Eugene But wrote: > It's quite unexpected that GetLastNonRedirectedItem can actually return a > redirect item. Is there a reason for that? Acknowledged. pkl (ping after 24h if needed) 2017/03/17 20:23:53 I'm inclined to preserve the existing behavior and Show quoted text On 2017/03/17 17:16:58, kkhorimoto_ wrote: > On 2017/03/17 14:32:04, Eugene But wrote: > > It's quite unexpected that GetLastNonRedirectedItem can actually return a > > redirect item. Is there a reason for that? > > The only use case of \|-lastUserItem\| was for reloading a page using a new user > agent, so if we traverse the whole history and the last one is a REDIRECT type, > we still return it because that's the best idea we have for the URL to attempt > to reload. You're right that this is unexpected behavior given the new naming. > Maybe we should just return nullptr in that case, then handle a null return > value when we're actually doing the reload. I'm inclined to preserve the existing behavior and then clean up separately.
	15 // all items are redirects.

	16 web::NavigationItem* GetLastNonRedirectedItem(

	17 web::NavigationManager* nav_manager);

	18

	19 #endif // IOS_CHROME_BROWSER_WEB_NAVIGATION_MANAGER_UTIL_H_

OLD	NEW