Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2756463006: fix ddc build, adds some unsupported methods to dart:io (Closed)

Created:
3 years, 9 months ago by Jennifer Messerly
Modified:
3 years, 9 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix ddc build, adds some unsupported methods to dart:io R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/13d6c5cd9897ad3871894b028537df1b4d50b9f0

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/tool/input_sdk/patch/io_patch.dart View 2 chunks +10 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
TBR
3 years, 9 months ago (2017-03-17 21:33:40 UTC) #2
vsm
lgtm https://codereview.chromium.org/2756463006/diff/1/pkg/dev_compiler/tool/input_sdk/patch/io_patch.dart File pkg/dev_compiler/tool/input_sdk/patch/io_patch.dart (right): https://codereview.chromium.org/2756463006/diff/1/pkg/dev_compiler/tool/input_sdk/patch/io_patch.dart#newcode255 pkg/dev_compiler/tool/input_sdk/patch/io_patch.dart:255: static _ansiSupported() { Looks like this one was ...
3 years, 9 months ago (2017-03-17 21:36:50 UTC) #3
Jennifer Messerly
https://codereview.chromium.org/2756463006/diff/1/pkg/dev_compiler/tool/input_sdk/patch/io_patch.dart File pkg/dev_compiler/tool/input_sdk/patch/io_patch.dart (right): https://codereview.chromium.org/2756463006/diff/1/pkg/dev_compiler/tool/input_sdk/patch/io_patch.dart#newcode255 pkg/dev_compiler/tool/input_sdk/patch/io_patch.dart:255: static _ansiSupported() { On 2017/03/17 21:36:50, vsm wrote: > ...
3 years, 9 months ago (2017-03-17 22:56:59 UTC) #4
Jennifer Messerly
3 years, 9 months ago (2017-03-17 23:24:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
13d6c5cd9897ad3871894b028537df1b4d50b9f0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698