Git ignore vscode project files.

Git ignore vscode project files.


Committed: https://github.com/dart-lang/sdk/commit/bcdcc6edb3456fbc6bd7c6ce7b33d888258eed21

[pquitslund, 2017-03-17 17:25:08]

pquitslund@google.com changed reviewers:
+ devoncarew@google.com, kevmoo@google.com

[kevmoo, 2017-03-17 17:29:21]

Is this for the SDK?

Shouldn't folks be ignoring these globally?

[pquitslund, 2017-03-17 17:31:42]

On 2017/03/17 17:29:21, kevmoo wrote:
> Is this for the SDK?

Yep.

> 
> Shouldn't folks be ignoring these globally?

Maybe?  But this makes things easy-peasy for everyone and is consistent with the
fact that this .gitignore already has ignores for IntelliJ and Eclipse.  It
feels right to keep all this metadata in one place...

[kevmoo, 2017-03-17 17:40:59]

On 2017/03/17 17:31:42, pquitslund wrote:
> On 2017/03/17 17:29:21, kevmoo wrote:
> > Is this for the SDK?
> 
> Yep.
> 
> > 
> > Shouldn't folks be ignoring these globally?
> 
> Maybe?  But this makes things easy-peasy for everyone and is consistent with
the
> fact that this .gitignore already has ignores for IntelliJ and Eclipse.  It
> feels right to keep all this metadata in one place...

One could argue we should remove those, too. :-)

http://www.goodreads.com/quotes/353571-a-foolish-consistency-is-the-hobgoblin...

[pquitslund, 2017-03-17 17:50:47]

On 2017/03/17 17:40:59, kevmoo wrote:
> On 2017/03/17 17:31:42, pquitslund wrote:
> > On 2017/03/17 17:29:21, kevmoo wrote:
> > > Is this for the SDK?
> > 
> > Yep.
> > 
> > > 
> > > Shouldn't folks be ignoring these globally?
> > 
> > Maybe?  But this makes things easy-peasy for everyone and is consistent with
> the
> > fact that this .gitignore already has ignores for IntelliJ and Eclipse.  It
> > feels right to keep all this metadata in one place...
> 
> One could argue we should remove those, too. :-)
> 
>
http://www.goodreads.com/quotes/353571-a-foolish-consistency-is-the-hobgoblin...

Well, assuming we actually agree then maybe.  That said, I'm not sure I actually
do.  Moreover, changing all the ignores would require something like process
and, ummmm, this doesn't justify that I don't think.  If you want to drive a
larger conversation, go for it though!

[kevmoo, 2017-03-17 18:02:57]

I defer to devon

[devoncarew, 2017-03-20 03:36:43]

I'd like to keep the IntelliJ ignores; I think it's important to have the Dart
team dogfooding as much of our dev. stack and tools as possible.

[pquitslund, 2017-03-20 04:33:36]

On 2017/03/20 03:36:43, devoncarew wrote:
> I'd like to keep the IntelliJ ignores; I think it's important to have the Dart
> team dogfooding as much of our dev. stack and tools as possible.

+1.

Are you OK with me adding the vscode ones as well?

[pquitslund, 2017-03-23 13:37:01]

pquitslund@google.com changed reviewers:
+ danrubel@google.com

[pquitslund, 2017-03-23 13:37:02]

Adding Dan (since Devon is out).

[danrubel, 2017-03-23 17:04:56]

LGTM

[pquitslund, 2017-03-23 22:27:20]

Description was changed from

==========
Git ignore vscode project files.

BUG=
==========

to

==========
Git ignore vscode project files.


Committed:
https://github.com/dart-lang/sdk/commit/bcdcc6edb3456fbc6bd7c6ce7b33d888258eed21
==========