[Cleanup] Remove the ability to disable Crash Reporting from the command line.

chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.preferences.privacy;
 
 import android.content.Context;
 import android.content.SharedPreferences;
 import android.net.ConnectivityManager;
 import android.net.NetworkInfo;
@@ skipping 25 matching lines @@
     private static final String PREF_PHYSICAL_WEB = "physical_web";
     private static final int PHYSICAL_WEB_OFF = 0;
     private static final int PHYSICAL_WEB_ON = 1;
     private static final int PHYSICAL_WEB_ONBOARDING = 2;
 
     private static PrivacyPreferencesManager sInstance;
 
     private final Context mContext;
     private final SharedPreferences mSharedPreferences;
 
-    private boolean mCrashUploadingDisabledByCommandLine;
-
     @VisibleForTesting
     PrivacyPreferencesManager(Context context) {
         mContext = context;
         mSharedPreferences = ContextUtils.getAppSharedPreferences();
 
-        // We default the command line flag to disable uploads unless altered on deferred startup
-        // to prevent unwanted uploads at startup. If the command line flag to enable uploading is
-        // turned on, the other conditions (e.g. user/network preferences) for when to upload apply.
-        // This currently applies to only crash reporting and is ignored for metrics reporting.
-        mCrashUploadingDisabledByCommandLine = true;
         migrateUsageAndCrashPreferences();
     }
 
     public static PrivacyPreferencesManager getInstance() {
         if (sInstance == null) {
             sInstance = new PrivacyPreferencesManager(ContextUtils.getApplicationContext());
         }
         return sInstance;
     }
 
@@ skipping 210 matching lines @@
      * Checks whether uploading of crash dumps is permitted for the available network(s).
      *
      * @return whether uploading crash dumps is permitted.
      */
     @Override
     public boolean isNetworkAvailableForCrashUploads() {
         return isNetworkAvailable() && isWiFiOrEthernetNetwork();
     }
 
     /**
-     * Checks whether uploading of crash dumps is permitted, based on the corresponding command line
-     * flag only.
-     * TODO(jchinlee): this is not quite a boolean. Depending on other refactoring, change to enum.
-     *
-     * @return whether uploading of crash dumps is enabled or disabled by a command line flag.
-     */
-    @Override
-    public boolean isCrashUploadDisabledByCommandLine() {
-        return mCrashUploadingDisabledByCommandLine;
-    }
-
-    /**
      * Checks whether uploading of usage metrics is currently permitted.
      *
-     * Note that this function intentionally does not check |mCrashUploadingDisabledByCommandLine|.
-     * See http://crbug.com/602703 for more details.
-     *
      * @return whether uploading usage metrics is currently permitted.
      */
     @Override
     public boolean isMetricsUploadPermitted() {
         return isNetworkAvailable()
                 && (isUsageAndCrashReportingPermittedByUser() || isUploadEnabledForTests());
     }
 
     /**
      * Checks whether uploading of usage metrics and crash dumps is currently permitted, based on
@@ skipping 12 matching lines @@
      * test devices to avoid UI manipulation.
      *
      * @return whether uploading should be enabled if at all possible.
      */
     @Override
     public boolean isUploadEnabledForTests() {
         return CommandLine.getInstance().hasSwitch(ChromeSwitches.FORCE_CRASH_DUMP_UPLOAD);
     }
 
     /**
-     * Provides a way to remove disabling crash uploading entirely.
-     * Enable crash uploading based on user's preference when an overriding flag does not exist in
-     * commandline.
-     * Used to differentiate from tests that trigger crashes intentionally, so these crashes are not
-     * uploaded.
-     */
-    public void enablePotentialCrashUploading() {
-        mCrashUploadingDisabledByCommandLine = false;
-    }
-
-    /**
      * Sets the Physical Web preference, which enables background scanning for bluetooth beacons
      * and displays a notification when beacons are found.
      *
      * @param enabled A boolean indicating whether to notify on nearby beacons.
      */
     public void setPhysicalWebEnabled(boolean enabled) {
         int state = enabled ? PHYSICAL_WEB_ON : PHYSICAL_WEB_OFF;
         boolean isOnboarding = isPhysicalWebOnboarding();
         mSharedPreferences.edit().putInt(PREF_PHYSICAL_WEB, state).apply();
         if (enabled) {
@@ skipping 18 matching lines @@
     /**
      * Check whether Physical Web is configured to notify on nearby beacons.
      *
      * @return boolean {@code true} if the feature is enabled.
      */
     public boolean isPhysicalWebEnabled() {
         int state = mSharedPreferences.getInt(PREF_PHYSICAL_WEB, PHYSICAL_WEB_ONBOARDING);
         return (state == PHYSICAL_WEB_ON);
     }
 }