third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp - Issue 2756463003: Remove opaque alpha channel special case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

Issue 2756463003: Remove opaque alpha channel special case (Closed)

Patch Set: Code review comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp ('K') | « third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp b/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

index 12e0b2fb8364ec0dc2fda772ca5eee3b80fb3bac..3547c833077483c6192211a76531843be1b2273f 100644

--- a/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

@@ -464,11 +464,10 @@ bool WEBPImageDecoder::DecodeSingleFrame(const uint8_t* data_bytes,

ColorSpaceForSkImages()))

return SetFailed();

buffer.ZeroFillPixelData();

- buffer.SetStatus(ImageFrame::kFramePartial);

// The buffer is transparent outside the decoded area while the image is

// loading. The correct alpha value for the frame will be set when it is

// fully decoded.

- buffer.SetHasAlpha(true);

+ buffer.SetStatus(ImageFrame::kFramePartial);

buffer.SetOriginalFrameRect(IntRect(IntPoint(), Size()));

}