third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp - Issue 2756463003: Remove opaque alpha channel special case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

Issue 2756463003: Remove opaque alpha channel special case (Closed)

Patch Set: Code review comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp ('K') | « third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp ('k') | third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

index 580b7a276a909bc107155ec8396134bd4670e364..a71544395423276ed7e52317202db09b4b521634 100644

--- a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

@@ -392,7 +392,7 @@ TEST(GIFImageDecoderTest, bitmapAlphaType) {

unpremul_frame->GetStatus() != ImageFrame::kFrameComplete);

EXPECT_EQ(unpremul_frame->Bitmap().alphaType(), kUnpremul_SkAlphaType);

- // Fully decoded frame => the frame alpha type is known (opaque).

+ // Fully decoded frame

premul_decoder->SetData(full_data.Get(), true);

ASSERT_TRUE(premul_decoder->FrameCount());

unpremul_decoder->SetData(full_data.Get(), true);