third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp - Issue 2756463003: Remove opaque alpha channel special case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp

Issue 2756463003: Remove opaque alpha channel special case (Closed)

Patch Set: Fix gif detecting if a frame claims to have transparency Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp ('K') | « third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp ('k') | third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.h » ('j') | third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp b/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp

index a0278445f7355aec98e2dd230d6c9837877a67a5..c9890b1dcb8f5a206994e84b76015189e4a867de 100644

--- a/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp

@@ -945,7 +945,6 @@ bool JPEGImageDecoder::outputScanlines() {

// The buffer is transparent outside the decoded area while the image is

// loading. The image will be marked fully opaque in complete().

buffer.setStatus(ImageFrame::FramePartial);

- buffer.setHasAlpha(true);

Peter Kasting 2017/03/22 23:37:47 I think this already got removed in another CL?

cblume 2017/05/08 10:28:02 I don't see it in any of my other CLs after a quic

// For JPEGs, the frame always fills the entire image.

buffer.setOriginalFrameRect(IntRect(IntPoint(), size()));