third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp - Issue 2756463003: Remove opaque alpha channel special case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp

Issue 2756463003: Remove opaque alpha channel special case (Closed)

Patch Set: Fix gif detecting if a frame claims to have transparency Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp b/third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp

index af1e07f91fda56196443c9254fd4f3151c1ca6c9..b7948bc5e2d102d7f46caba084be9dfa725a6f31 100644

--- a/third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp

@@ -78,8 +78,8 @@ void ImageFrame::clearPixelData() {

}

void ImageFrame::zeroFillPixelData() {

+ setHasAlpha(true);

Peter Kasting 2017/03/22 23:37:46 Seems like this shouldn't be here given patches el

cblume 2017/05/08 10:28:02 Done.

m_bitmap.eraseARGB(0, 0, 0, 0);

- m_hasAlpha = true;

}

bool ImageFrame::copyBitmapData(const ImageFrame& other) {