Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart

Issue 2756443004: Share operator names (Closed)
Patch Set: Share operator names Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart b/pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart
index 825bb1b691151a0554475601cd30b1d42c3f65a1..efe90bd120580538dae35423d2ada369ce7b68b6 100644
--- a/pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart
@@ -33,6 +33,8 @@ import 'frontend_accessors.dart' show buildIsNull, makeLet;
import 'kernel_builder.dart'
show Builder, KernelClassBuilder, PrefixBuilder, TypeDeclarationBuilder;
+import '../names.dart' show callName;
+
abstract class BuilderHelper {
Uri get uri;
@@ -231,7 +233,7 @@ class ThisAccessor extends BuilderAccessor {
return buildConstructorInitializer(charOffset, new Name(""), arguments);
} else {
return buildMethodInvocation(
- new ThisExpression(), new Name("call"), arguments, charOffset);
+ new ThisExpression(), callName, arguments, charOffset);
}
}
@@ -354,11 +356,8 @@ class SendAccessor extends IncompleteSend {
Member target = builder.target;
if (target != null) {
if (target is Field) {
- result = buildMethodInvocation(
- new StaticGet(target),
- new Name("call"),
- arguments,
- charOffset + (target.name?.name?.length ?? 0),
+ result = buildMethodInvocation(new StaticGet(target), callName,
+ arguments, charOffset + (target.name?.name?.length ?? 0),
isNullAware: isNullAware);
} else {
result = helper.buildStaticInvocation(target, arguments)
@@ -495,7 +494,7 @@ class IndexAccessor extends kernel.IndexAccessor with BuilderAccessor {
Expression doInvocation(int charOffset, Arguments arguments) {
return buildMethodInvocation(
- buildSimpleRead(), new Name("call"), arguments, charOffset);
+ buildSimpleRead(), callName, arguments, charOffset);
}
toString() => "IndexAccessor()";
@@ -587,8 +586,8 @@ class StaticAccessor extends kernel.StaticAccessor with BuilderAccessor {
Expression doInvocation(int charOffset, Arguments arguments) {
if (readTarget == null || isFieldOrGetter(readTarget)) {
- return buildMethodInvocation(buildSimpleRead(), new Name("call"),
- arguments, charOffset + (readTarget?.name?.name?.length ?? 0));
+ return buildMethodInvocation(buildSimpleRead(), callName, arguments,
+ charOffset + (readTarget?.name?.name?.length ?? 0));
} else {
return helper.buildStaticInvocation(readTarget, arguments)
..fileOffset = charOffset;
@@ -611,7 +610,7 @@ class SuperPropertyAccessor extends kernel.SuperPropertyAccessor
Expression doInvocation(int charOffset, Arguments arguments) {
if (getter == null || isFieldOrGetter(getter)) {
return buildMethodInvocation(
- buildSimpleRead(), new Name("call"), arguments, charOffset);
+ buildSimpleRead(), callName, arguments, charOffset);
} else {
return new DirectMethodInvocation(new ThisExpression(), getter, arguments)
..fileOffset = charOffset;
@@ -636,7 +635,7 @@ class ThisIndexAccessor extends kernel.ThisIndexAccessor with BuilderAccessor {
Expression doInvocation(int charOffset, Arguments arguments) {
return buildMethodInvocation(
- buildSimpleRead(), new Name("call"), arguments, charOffset);
+ buildSimpleRead(), callName, arguments, charOffset);
}
toString() => "ThisIndexAccessor()";
@@ -658,7 +657,7 @@ class SuperIndexAccessor extends kernel.SuperIndexAccessor
Expression doInvocation(int charOffset, Arguments arguments) {
return buildMethodInvocation(
- buildSimpleRead(), new Name("call"), arguments, charOffset);
+ buildSimpleRead(), callName, arguments, charOffset);
}
toString() => "SuperIndexAccessor()";
@@ -721,7 +720,7 @@ class VariableAccessor extends kernel.VariableAccessor with BuilderAccessor {
Expression doInvocation(int charOffset, Arguments arguments) {
// Normally the offset is at the start of the token, but in this case,
// because we insert a '.call', we want it at the end instead.
- return buildMethodInvocation(buildSimpleRead(), new Name("call"), arguments,
+ return buildMethodInvocation(buildSimpleRead(), callName, arguments,
charOffset + (variable.name?.length ?? 0));
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/body_builder.dart ('k') | pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698