components/arc/net/DEPS - Issue 2756443003: arc: Update device owner check implementation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/arc/net/DEPS

Issue 2756443003: arc: Update device owner check implementation (Closed)

Patch Set: Update deps order, commit message and add comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 "+chrome/browser/chromeos/login/users",
	Luis Héctor Chávez 2017/03/16 19:23:38 eek, this is not allowed D: (as indicated by the p eek, this is not allowed D: (as indicated by the preupload failures) you'll have to create a Delegate that does the IsDeviceOwner() check and pass that from chrome/browser/chromeos/arc. xiyuan 2017/03/16 19:29:21 Right, components could not depend on chrome. Miss Show quoted text On 2017/03/16 19:23:38, Luis Héctor Chávez wrote: > eek, this is not allowed D: (as indicated by the preupload failures) > > you'll have to create a Delegate that does the IsDeviceOwner() check and pass > that from chrome/browser/chromeos/arc. Right, components could not depend on chrome. Missed that... Instead of using GetOwnerAccountId from ChromeUserManager, you should use the UserManager interface from components/user_manager. abhishekbh 2017/03/16 20:57:09 Done. Show quoted text On 2017/03/16 19:23:38, Luis Héctor Chávez wrote: > eek, this is not allowed D: (as indicated by the preupload failures) > > you'll have to create a Delegate that does the IsDeviceOwner() check and pass > that from chrome/browser/chromeos/arc. Done.
2 "+chromeos/login",	3 "+chromeos/login",

3 "+chromeos/network",	4 "+chromeos/network",

4 "+components/onc",	5 "+components/onc",

5 ]	6 ]

OLD	NEW

« no previous file with comments | « no previous file | components/arc/net/arc_net_host_impl.cc » ('j') | no next file with comments »