Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.h

Issue 2756393002: Deflake ImageWriterUtilityClient browsertest and clients (Closed)
Patch Set: Remove progress case from Cancel test. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.h
diff --git a/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.h b/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.h
index ad122fc213ea238f8b4614862af777cb0e167397..0df6304205c1f3309c5e6c5ac5f979b51b0d8ec8 100644
--- a/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.h
+++ b/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.h
@@ -15,7 +15,8 @@
#include "chrome/common/extensions/removable_storage_writer.mojom.h"
#include "content/public/browser/utility_process_mojo_client.h"
-// Writes a disk image to a device inside the utility process.
+// Writes a disk image to a device inside the utility process. This
+// class lives on the FILE thread.
class ImageWriterUtilityClient
: public base::RefCountedThreadSafe<ImageWriterUtilityClient> {
public:
@@ -52,6 +53,7 @@ class ImageWriterUtilityClient
// Cancels any pending write or verify operation.
// |cancel_callback|: Called when the cancel has actually occurred.
+ // TODO(crbug.com/703514): Consider removing this API.
virtual void Cancel(const CancelCallback& cancel_callback);
// Shuts down the utility process that may have been created.
@@ -78,8 +80,6 @@ class ImageWriterUtilityClient
SuccessCallback success_callback_;
ErrorCallback error_callback_;
- const scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
-
std::unique_ptr<content::UtilityProcessMojoClient<
extensions::mojom::RemovableStorageWriter>>
utility_process_mojo_client_;
« no previous file with comments | « no previous file | chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698