Issue 27563002: Adds missing USB events to the imageWriterPrivate API definition.

Issue 27563002: Adds missing USB events to the imageWriterPrivate API definition. (Closed)

Created:
7 years, 2 months ago by Drew Haven

Modified:
7 years, 1 month ago

Reviewers:
miket_OOO

CC:
stephenlin1, chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Adds missing USB events to the imageWriterPrivate API definition. BUG=308191 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233421

Patch Set 2 : Edits comments to be consistent with variable naming. #

Patch Set 3 : Realigns verbs. #

Patch Set 4 : Resync #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	chrome/common/extensions/api/image_writer_private.idl	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Drew Haven

I forgot to add two events to the IDL file. The Recovery Tool wants them ...

7 years, 1 month ago (2013-11-01 00:48:29 UTC) #1

miket_OOO

Subject to comments, LGTM. https://codereview.chromium.org/27563002/diff/1/chrome/common/extensions/api/image_writer_private.idl File chrome/common/extensions/api/image_writer_private.idl (right): https://codereview.chromium.org/27563002/diff/1/chrome/common/extensions/api/image_writer_private.idl#newcode135 chrome/common/extensions/api/image_writer_private.idl:135: static void onDeviceRemoved(RemovableStorageDevice device); Please ...

7 years, 1 month ago (2013-11-01 14:51:16 UTC) #2

Drew Haven

Thanks for the quick review. Sorry about the sloppiness. I changed it to Inserted/Removed. https://codereview.chromium.org/27563002/diff/1/chrome/common/extensions/api/image_writer_private.idl ...

7 years, 1 month ago (2013-11-01 17:07:14 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haven@chromium.org/27563002/53001

7 years, 1 month ago (2013-11-01 17:07:37 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=170711

7 years, 1 month ago (2013-11-01 19:10:08 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haven@chromium.org/27563002/303001

7 years, 1 month ago (2013-11-06 19:45:57 UTC) #6

Message was sent while issue was closed.

Change committed as 233421

Expand Messages | Collapse Messages