Issue 275623002: Split Star into Star (stores nothing) and List (stores matches).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 275623002: Split Star into Star (stores nothing) and List (stores matches). (Closed)

Created:
6 years, 7 months ago by mtklein_C

Modified:
6 years, 7 months ago

Reviewers:
bungeman-skia, f(malita), mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Split Star into Star (stores nothing) and List (stores matches). Just noticed that the cull noop pattern (PushCull, Star<NoOp>, PopCull) would trigger the Star that stores matches. We certainly don't need those matches here, so instead of magically determining which Star you need, we'll make you tell us which one you want. No one but List's unit test needs List. I'll leave it for now, but we might find it's not useful. BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14655

Patch Set 1 #

Patch Set 2 : nits #

Patch Set 3 : yagni #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -38 lines)			Patch
	M	src/record/SkRecordPattern.h	View	1 2	2 chunks	+3 lines, -35 lines	0 comments	Download
	M	tests/RecordPatternTest.cpp	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/275623002/40001

6 years, 7 months ago (2014-05-08 18:50:48 UTC) #5

Message was sent while issue was closed.

Change committed as 14655

Expand Messages | Collapse Messages